Closed
Bug 1386868
Opened 7 years ago
Closed 3 years ago
History and PageMetadata should be joined by History._ID, not History.GUID
Categories
(Firefox for Android Graveyard :: Data Providers, enhancement)
Tracking
(Not tracked)
RESOLVED
INCOMPLETE
People
(Reporter: mcomella, Unassigned)
Details
From Grisha, bug 1386052 comment #6: > Well, this is unfortunate. I think using history_guid in the pagemetadata > table was a mistake. It's really a sync-centric field, we won't be syncing > this data in this shape or form anyway, and so using a local _id field > likely would have been just fine. As thing stand, without either an > additional compound select ran after top sites are generated (_id -> guid -> > metadata), or a what you're proposing as option 1, you can't really > associate the two tables easily.
Reporter | ||
Comment 1•7 years ago
|
||
In bug 1386052, I'm also adding Combined.HISTORY_GUID to the Combined view (bookmarks & history) and the get top sites temporary table so that the top sites results can be joined with the PageMetadata table: it'd be great to revert these changes.
Comment 2•7 years ago
|
||
(In reply to Michael Comella (:mcomella) from comment #1) > In bug 1386052, I'm also adding Combined.HISTORY_GUID to the Combined view > (bookmarks & history) and the get top sites temporary table so that the top > sites results can be joined with the PageMetadata table: it'd be great to > revert these changes. Once those changes are in and the immediate problems are addressed, this work starts to feel like unnecessary churn.
Comment 3•3 years ago
|
||
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INCOMPLETE
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•