1387034 - Layout issue on 54.0.1 firstrun page

Status: RESOLVED FIXED

(www.mozilla.org :: Pages & Content, defect)

Description

[Michael Köhler [:Coce]]

Attachment: Screenshot of issue

Hi,

As is being reported on the German Firefox forum, there appears to be a layout issue on the German Firefox 54.0.1 firstrun page <https://www.mozilla.org/de/firefox/54.0.1/firstrun/>.

The hyperlinked part „Erfahren Sie mehr über Firefox-Konten” overlaps the final line of the non-linked text.


The problem does not appear in English, Italian or Spanish but is also present in French <https://www.mozilla.org/fr/firefox/54.0.1/firstrun/>.


Might this be an issue caused by the number of lines in the paragraph without links or is something wrong on my part?

Thanks for taking a look.

Comment 1

[Alex Gibson [:agibson]]

I'll take a poke at this

Comment 2

[Alex Gibson [:agibson]]

Attachment: GitHub pull request

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/6f2738d06b5235533dfa192d7d60d8f50b2fa43b
[fix bug 1387034] L10n layout issue on /firstrun page

https://github.com/mozilla/bedrock/commit/70bc40736c12fba9de6742f6862af487b74f85d7
Merge pull request #5025 from alexgibson/1387034-bug-firstrun-l10-bug

[fix bug 1387034] L10n layout issue on /firstrun page

Comment 5

[Michael Köhler [:Coce]]

Thanks for the update. Am I the only one who can still see the aforementioned issue on both the German and French pages?

https://www.mozilla.org/de/firefox/54.0.1/firstrun/
https://www.mozilla.org/fr/firefox/54.0.1/firstrun/

Comment 6

[Francesco Lodolo [:flod]]

That's expected
https://www-dev.allizom.org/de/firefox/54.0.1/firstrun/

In landed in GitHub and visible in DEV, pushes to production usually a few times a week, last one on Aug 2
https://github.com/mozilla/bedrock/releases

Comment 7

[Michael Köhler [:Coce]]

Got it, thanks.