Closed
Bug 1387134
Opened 7 years ago
Closed 7 years ago
out-of-line type-specific Pickle::Write* methods
Categories
(Core :: IPC, enhancement)
Core
IPC
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(1 file)
|
8.25 KB,
patch
|
billm
:
review+
|
Details | Diff | Splinter Review |
Having these functions declared in the class definition and therefore inlined means that every call site is bloated by having to store the argument so its address can be taken and load the sizeof() constant. There's no good reason that we should be doing this; the Read* counterparts are also out-of-lined, which hasn't seemed to cause any problems. Moving these out-of-line saves about 200K (!) of space on x86-64 Linux.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8893472 -
Flags: review?(wmccloskey)
Attachment #8893472 -
Flags: review?(wmccloskey) → review+
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c541ddcbcac5 out-of-line type-specific Pickle::Write* methods; r=billm
|
|
||
Comment 3•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c541ddcbcac5
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•