1387149 - Remove outdated comment from Codegen.py: "We don't enforce this for chrome [...] to avoid addon compat fallout"

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[Markus Stange [:mstange]]

http://searchfox.org/mozilla-central/rev/f0e4ae5f8c40ba742214e89aba3f554da0b89a33/dom/bindings/Codegen.py#1766 :

> # Additionally, we want to throw if a caller does a bareword invocation
> # of a constructor without |new|. We don't enforce this for chrome in
> # realease builds to avoid the addon compat fallout of making that
> # change. See bug 916644.

I think we started applying this restriction for chrome in release builds in bug 979591.

Comment 1

[Eden Chuang[:edenchuang]]

Attachment: Bug 1387149 - Remove outdated comment from Codegen.py. r?bz

Hello Bz, could you help to review this patch for removing outdated comments from Codegen.py? Thanks.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8895294 [details] [diff] [review]
Bug 1387149 - Remove outdated comment from Codegen.py. r?bz

Please leave the part about how we throw for bareword invocations; that's important.

r=me with that.

Comment 3

[Eden Chuang[:edenchuang]]

Attachment: Bug 1387419 - Remove outdated comment from Codegen.py. r=bz

Update patch according to comment 2. Keep the comment

# Additionally, we want to throw if a caller does a bareword invocation
# of a constructor without |new|.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/227388c78b76
Remove outdated comment from Codegen.py. r=bz

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/227388c78b76