1387307 - Add FailedCommandError(message, exit_code) s.t. mach won't print a stack-trace

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, enhancement)

Description

[Jonas Finnemann Jensen (:jonasfj)]

Simply a way to communicate expected errors nicely without littering our code
with:
  print(...)
  sys.exit(1)

which makes it hard to reuse code for anything other than the command it was written for.

Comment 1

[Jonas Finnemann Jensen (:jonasfj)]

Attachment: Bug 1387307 - Add FailedCommandError to mach

Review commit: https://reviewboard.mozilla.org/r/164740/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/164740/

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8893638 [details]
Bug 1387307 - Add FailedCommandError to mach

https://reviewboard.mozilla.org/r/164740/#review170954

::: python/mach/mach/main.py:457
(Diff revision 1)
>              return Registrar._run_command_handler(handler, context=context,
>                  debug_command=args.debug_command, **vars(args.command_args))
>          except KeyboardInterrupt as ki:
>              raise ki
> +        except FailedCommandError as e:
> +            print(e.message, file=sys.stderr)

While stderr is arguably the correct destination, other error handling code in this file writes to stdout. So let's drop `file=sys.stderr` and write to stdout.

Comment 3

[Jonas Finnemann Jensen (:jonasfj)]

Comment on attachment 8893638 [details]
Bug 1387307 - Add FailedCommandError to mach

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/164740/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f5a478a70af0
Add FailedCommandError to mach r=gps

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f5a478a70af0