1387495 - dt-addon: use window object in webconsole/net/main to load stylesheets

Status: RESOLVED FIXED

(DevTools :: General, enhancement, P3)

Description

[Julian Descottes [:jdescottes]]

We can land this dependency of Bug 1369801 as it works both if DevTools are a system addon or not.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1387495 - dt-addon: use window object in webconsole/net/main to load stylesheets;

From console/net/main.js we are calling loadSheet from sdk/stylesheet/utils.
This API needs a real window object to work, but now that devtools are loaded
as a system addon, by default the global object is a sandbox wrapper.

Use the window object which points to the actual Window instead.

Review commit: https://reviewboard.mozilla.org/r/164960/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/164960/

Comment 2

[Julian Descottes [:jdescottes]]

This is the exact same patch as the one r+'d in Bug 1369801, but I prefer to validate with the reviewer rather than setting r+ directly.

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8893869 [details]
Bug 1387495 - dt-addon: use window object in webconsole/net/main to load stylesheets;

https://reviewboard.mozilla.org/r/164960/#review170352

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1256610b4f38
dt-addon: use window object in webconsole/net/main to load stylesheets;r=jryans

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/1256610b4f38