1387723 - Remove --toolbarbutton-icon-fill and --toolbarbutton-icon-fill-inverted

Status: RESOLVED FIXED

(Firefox :: Theme, enhancement)

Description

[Dão Gottwald [:dao]]

--toolbarbutton-icon-fill and --toolbarbutton-icon-fill-inverted are largely unused; only the dark theme uses --toolbarbutton-icon-fill-inverted as intended to change icon colors. The variables are footguns in that people think they should somehow use them when they really shouldn't, see bug 1384898, bug 1384893, bug 1384895, and pocket.css.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1387723 - Remove --toolbarbutton-icon-fill and --toolbarbutton-icon-fill-inverted.

--toolbarbutton-icon-fill and --toolbarbutton-icon-fill-inverted are largely unused;
only the dark theme uses --toolbarbutton-icon-fill-inverted as intended to change
icon colors. The variables are footguns in that people think they should somehow use
them when they really shouldn't, see bug 1384898, bug 1384893, bug 1384895, and
pocket.css.

Review commit: https://reviewboard.mozilla.org/r/165182/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/165182/

Comment 2

[Tim Nguyen :ntim]

It would be nice if we could simply use currentColor + some (fill-)opacity rules, and avoid setting any colors.

This way, it's possible to get rid of the clumsy brighttext attributes/pseudo selectors and simply rely on the text color.

Comment 3

[Johann Hofmann [:johannh]]

Comment on attachment 8894086 [details]
Bug 1387723 - Remove --toolbarbutton-icon-fill and --toolbarbutton-icon-fill-inverted.

https://reviewboard.mozilla.org/r/165182/#review170684

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2526325fcf8e
Remove --toolbarbutton-icon-fill and --toolbarbutton-icon-fill-inverted. r=johannh

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2526325fcf8e