1387912 - nightly 20170804 compile failed - error: ‘gfxAlphaType’ does not name a type

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[u532768]

Attachment: custom .mozconfig that I am using

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:54.0) Gecko/20100101 Firefox/54.0
Build ID: 20170725113151

Steps to reproduce:

Updated hg repository to latest nightly version, compiled, got the error.  This is on an up to date Fedora 25.


Actual results:

20:05.42 In file included from /mnt/to_archive/accum/src/mozilla-central/obj-x86_64-pc-linux-gnu/dom/bindings/OffscreenCanvasBinding.cpp:9:0,
20:05.42                  from /mnt/to_archive/accum/src/mozilla-central/obj-x86_64-pc-linux-gnu/dom/bindings/UnifiedBindings12.cpp:50:
20:05.42 /mnt/to_archive/accum/src/mozilla-central/obj-x86_64-pc-linux-gnu/dist/include/mozilla/dom/ImageBitmap.h:66:3: error: ‘gfxAlphaType’ does not name a type
20:05.42    gfxAlphaType mAlphaType;
20:05.42    ^~~~~~~~~~~~
20:05.42 /mnt/to_archive/accum/src/mozilla-central/obj-x86_64-pc-linux-gnu/dist/include/mozilla/dom/ImageBitmap.h:203:15: error: ‘gfxAlphaType’ has not been declared
20:05.42                gfxAlphaType aAlphaType = gfxAlphaType::Premult);
20:05.42                ^~~~~~~~~~~~
20:05.42 /mnt/to_archive/accum/src/mozilla-central/obj-x86_64-pc-linux-gnu/dist/include/mozilla/dom/ImageBitmap.h:275:9: error: ‘gfxAlphaType’ does not name a type
20:05.42    const gfxAlphaType mAlphaType;
20:05.42          ^~~~~~~~~~~~
20:05.42 /mnt/to_archive/accum/src/mozilla-central/obj-x86_64-pc-linux-gnu/dist/include/mozilla/dom/ImageBitmap.h:203:41: error: ‘gfxAlphaType’ has not been declared
20:05.42                gfxAlphaType aAlphaType = gfxAlphaType::Premult);
20:05.42                                          ^~~~~~~~~~~~
20:05.42 /mnt/to_archive/accum/src/mozilla-central/config/rules.mk:1050: recipe for target 'UnifiedBindings12.o' failed
20:05.42 gmake[5]: *** [UnifiedBindings12.o] Error 1
20:05.42 /mnt/to_archive/accum/src/mozilla-central/config/recurse.mk:73: recipe for target 'dom/bindings/target' failed
20:05.42 gmake[4]: *** [dom/bindings/target] Error 2
20:05.42 gmake[4]: *** Waiting for unfinished jobs....


Expected results:

successful compile

Comment 1

[Jonathan Kew [:jfkthame]]

If you add

  #include "gfxTypes.h"

to the includes at the start of dom/canvas/ImageBitmap.h, does that resolve the problem?

Comment 2

[u532768]

Yes, that worked.

Comment 3

[Jonathan Kew [:jfkthame]]

Attachment: Add missing #include to dom/canvas/ImageBitmap.h, to avoid build fragility (unified-compilation dependency)

Comment 4

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/22734f3d4b603253f6e9ba1b4ff9bd36e4a73712
Bug 1387912 - Add missing #include to dom/canvas/ImageBitmap.h, to avoid build fragility (unified-compilation dependency. r=jrmuizel

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/65826179c86e
Add missing #include to dom/canvas/ImageBitmap.h, to avoid build fragility (unified-compilation dependency. r=jrmuizel a=stability

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/65826179c86e

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/22734f3d4b60

Comment 9

[u532768]

Yes, nightly compiles fine with this fix.

Thanks.