Closed
Bug 1387940
Opened 7 years ago
Closed 7 years ago
Make --max-frames=8 the default for dmd.py
Categories
(Core :: DMD, enhancement)
Core
DMD
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
Details
Attachments
(1 file)
|
4.24 KB,
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
The current default is 24, which is equal to the maximum number of stack frames that DMD will record. And that's a terrible value because it splits up too many related stack traces into separate records. There is no single best value, but 8 is a much better default.
|
Assignee | |
Comment 1•7 years ago
|
||
mccr8, I've changed block_analyzer.py in the same way. Is that reasonable?
Attachment #8894395 -
Flags: review?(continuation)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8894395 [details] [diff] [review] Make --max-frames=8 the default for dmd.py Review of attachment 8894395 [details] [diff] [review]: ----------------------------------------------------------------- I don't remember what role that plays in block_analyzer, but I'm sure it is fine.
Attachment #8894395 -
Flags: review?(continuation) → review+
|
|
Assignee | |
Comment 3•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/37f23109abe315376b245372df442ed0663c323d Bug 1387940 - Make --max-frames=8 the default for dmd.py. r=mccr8.
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/37f23109abe3
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•