1388107 - Support unknown capability values in the sitePermissions.xul dialog.

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P3)

Comment 1

[:prathiksha]

Attachment: Bug 1388107 - Support unknown capability values in the sitePermissions.xul dialog.

Review commit: https://reviewboard.mozilla.org/r/185648/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/185648/

Comment 2

[Johann Hofmann [:johannh]]

Comment on attachment 8914372 [details]
Bug 1388107 - Support unknown capability values in the sitePermissions.xul dialog.

https://reviewboard.mozilla.org/r/185648/#review191452

Thanks!

::: browser/components/preferences/sitePermissions.js:74
(Diff revision 1)
>        return;
>  
>      let permission = subject.QueryInterface(Components.interfaces.nsIPermission);
>  
> -    // Ignore unrelated permission types.
> -    if (permission.type !== this._type)
> +    // Ignore unrelated permission types and permissions with unknown states.
> +    let states = [SitePermissions.ALLOW, SitePermissions.BLOCK, SitePermissions.PROMPT];

Nit: you could make this a constant

Comment 3

[:prathiksha]

Comment on attachment 8914372 [details]
Bug 1388107 - Support unknown capability values in the sitePermissions.xul dialog.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/185648/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/85888997be88
Support unknown capability values in the sitePermissions.xul dialog. r=johannh

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/85888997be88

Comment 6

[:prathiksha]

Comment on attachment 8914372 [details]
Bug 1388107 - Support unknown capability values in the sitePermissions.xul dialog.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1373206
[User impact if declined]: chances of site permissions dialog breaking
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: no
[Is the change risky?]: no
[Why is the change risky/not risky?]: just an edge case fix
[String changes made/needed]: no

Comment 7

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8914372 [details]
Bug 1388107 - Support unknown capability values in the sitePermissions.xul dialog.

Photon polish, Beta57+

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8eb38d9ed82c