1388132 - Telemetry for XMLDocument.async to gauge feasibility of removal

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

No other UA supports this, so it's likely to be basically nothing, but let's check anyway.

Comment 1

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Attachment: Bug 1388132 - Enable use counter for XMLDocument.async;

This API is Gecko-only and we want to ensure there isn't significant
usage before removing it.

Review commit: https://reviewboard.mozilla.org/r/165996/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/165996/

Comment 2

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Comment on attachment 8894838 [details]
Bug 1388132 - Enable use counter for XMLDocument.async;

Requesting data review.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

AFAIK IE supports .async. Wasn't that the reason to add it.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8894838 [details]
Bug 1388132 - Enable use counter for XMLDocument.async;

https://reviewboard.mozilla.org/r/165996/#review171302

::: commit-message-52285:3
(Diff revision 1)
> +Bug 1388132 - Enable use counter for XMLDocument.async; r?smaug
> +
> +This API is Gecko-only and we want to ensure there isn't significant

This comment looks wrong. .async is/was IEism.
See for example
https://msdn.microsoft.com/en-us/library/ms761398(v=vs.85).aspx

::: dom/base/UseCounters.conf:82
(Diff revision 1)
>  method DataTransfer.mozSetDataAt
>  method DataTransfer.mozGetDataAt
>  attribute DataTransfer.mozUserCancelled
>  attribute DataTransfer.mozSourceNode
> +
> +// Gecko-only property

Drop the comment

Comment 5

[François Marier [:francois]]

Comment on attachment 8894838 [details]
Bug 1388132 - Enable use counter for XMLDocument.async;

https://reviewboard.mozilla.org/r/165996/#review171306

datareview+

Comment 6

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Comment on attachment 8894838 [details]
Bug 1388132 - Enable use counter for XMLDocument.async;

https://reviewboard.mozilla.org/r/165996/#review171302

> This comment looks wrong. .async is/was IEism.
> See for example
> https://msdn.microsoft.com/en-us/library/ms761398(v=vs.85).aspx

https://jsfiddle.net/wu6e266o/ reports "undefined" in Edge, IE11, and IE11 with IE10 compatibility mode, and "true" in Firefox.  (IE9 compatibility mode doesn't load the page properly.)  So we are the only browser that implements it.  The docs page says that it's from MSXML, which Wikipedia says is a legacy set of services for developers of Windows programs, not part of IE.

Comment 7

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Comment on attachment 8894838 [details]
Bug 1388132 - Enable use counter for XMLDocument.async;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/165996/diff/1-2/

Comment 8

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Comment on attachment 8894838 [details]
Bug 1388132 - Enable use counter for XMLDocument.async;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/165996/diff/2-3/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d5a7aa8a32ea
Enable use counter for XMLDocument.async; r=francois,smaug

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d5a7aa8a32ea