1388208 - Stop using FileUtils.getFile

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement)

Description

[Kris Maglione [:kmag]]

This performs main thread IO to make sure that directories exist, which is not something we should be doing on the startup path.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1388208: Stop using FileUtils.getFile.

This performs main thread IO to make sure that directories exist, which is not
something we should be doing on the startup path.

Review commit: https://reviewboard.mozilla.org/r/165858/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/165858/

Comment 2

[Tomislav Jovanovic :zombie]

Comment on attachment 8894697 [details]
Bug 1388208: Stop using FileUtils.getFile.

Kris "asked" me to steal the review.

Comment 3

[Tomislav Jovanovic :zombie]

Comment on attachment 8894697 [details]
Bug 1388208: Stop using FileUtils.getFile.

https://reviewboard.mozilla.org/r/165858/#review171174

::: toolkit/components/extensions/ExtensionParent.jsm:1414
(Diff revision 1)
>    async _readData() {
>      let result = new Map();
>      try {
>        let data = await promiseFileContents(this.file);
>  
>        result = aomStartup.decodeBlob(data);

Now that we switched to `OS.File.read()` which supports compression directly, can we eliminate this dependency on `aomStartup`?

Comment 4

[Kris Maglione [:kmag]]

Comment on attachment 8894697 [details]
Bug 1388208: Stop using FileUtils.getFile.

https://reviewboard.mozilla.org/r/165858/#review171174

> Now that we switched to `OS.File.read()` which supports compression directly, can we eliminate this dependency on `aomStartup`?

This isn't compression. It's structured clone deserialization.

Comment 5

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/903db0ac80c6a27b61b68e7df699782acc7f8842
Bug 1388208: Stop using FileUtils.getFile. r=zombie

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/903db0ac80c6

Comment 7

[(no longer active)]

Would it make sense to add an eslint rule to ban further usage of FileUtils.getFile()?

Comment 8

[:Paolo Amadini]

(In reply to :Ehsan Akhgari (needinfo please, extremely long backlog, Away 8/18) from comment #7)
> Would it make sense to add an eslint rule to ban further usage of
> FileUtils.getFile()?

We should just migrate the callers and remove the function. Bug 920187 was already on file to do that, but in the meantime I filed bug 1391576 for the low-hanging fruit.