Closed
Bug 1388684
Opened 7 years ago
Closed 7 years ago
RCWN breaks HTTP_CHANNEL_DISPOSITION telemetry
Categories
(Core :: Networking: Cache, enhancement)
Core
Networking: Cache
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: michal, Assigned: michal)
Details
(Whiteboard: [necko-active])
Attachments
(1 file)
|
1.19 KB,
patch
|
mcmanus
:
review+
|
Details | Diff | Splinter Review |
When racing cache with network mUsedNetwork is always true. Should we report value according to who wins or should we add new values? Btw, the current code reports kHttpNetOK when we revalidate the cache entry with server and use the cached content. Is this OK?
|
Assignee | |
Updated•7 years ago
|
Flags: needinfo?(mcmanus)
|
||
Comment 1•7 years ago
|
||
(In reply to Michal Novotny (:michal) from comment #0) > When racing cache with network mUsedNetwork is always true. Should we report > value according to who wins or should we add new values? according to who wins > > Btw, the current code reports kHttpNetOK when we revalidate the cache entry > with server and use the cached content. Is this OK? yeah that's the right thing. The transaction required the network and it went ok.
Flags: needinfo?(mcmanus)
|
|
Assignee | |
Comment 2•7 years ago
|
||
Assignee: nobody → michal.novotny
Attachment #8897043 -
Flags: review?(mcmanus)
|
|
Assignee | |
Updated•7 years ago
|
Whiteboard: [necko-active]
|
|
||
Updated•7 years ago
|
Attachment #8897043 -
Flags: review?(mcmanus) → review+
Pushed by mnovotny@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/05448985c4cb RCWN breaks HTTP_CHANNEL_DISPOSITION telemetry, r=mcmanus
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/05448985c4cb
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•