Closed Bug 1388902 Opened 7 years ago Closed 7 years ago

Shut down the last of socialapi

Categories

(Firefox Graveyard :: SocialAPI, enhancement)

Product:
Firefox Graveyard
Component:
SocialAPI
Version:
50 Branch
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(relnote-firefox 57+, firefox57 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 57
Tracking Flags:
Tracking Status
relnote-firefox --- 57+
firefox57 --- fixed

People

(Reporter: mixedpuppy, Assigned: mixedpuppy)

References

Details

(Keywords: dev-doc-complete, site-compat, Whiteboard: [tor 13612])

Attachments

(1 file)

Bug 1388902 remove socialapi share,
59 bytes, text/x-review-board-request
florian
: review+
Details 
The last element of SocialAPI, Share, is growing into a state of disrepair.  Now that webextensions are capable of reproducing what Share is, we'll just remove the last bits and maybe find time to implement Share as a webextension pageAction.
Assignee: nobody → mixedpuppy
Blocks: 1389630
Comment on attachment 8895580 [details]
Bug 1388902 remove socialapi share,

https://reviewboard.mozilla.org/r/166778/#review173022

::: browser/themes/shared/menupanel.inc.css
(Diff revision 3)
>  /* Menu panel and palette styles */
>  
> -#add-share-provider {
> -  list-style-image: url(chrome://browser/skin/menuPanel-small.svg);

This makes menuPanel-small.svg unused, please remove it (browser_all_files_referenced.js will fail if you don't.)
Comment on attachment 8895580 [details]
Bug 1388902 remove socialapi share,

https://reviewboard.mozilla.org/r/166778/#review173032

::: browser/base/content/browser.js:36
(Diff revision 3)
>            PluralForm:false, PrivateBrowsingUtils:false,
>            ProcessHangMonitor:false, PromiseUtils:false, ReaderMode:false,
>            ReaderParent:false, RecentWindow:false, SafeBrowsing: false,
>            SessionStore:false,
>            ShortcutUtils:false, SimpleServiceDiscovery:false, SitePermissions:false,
> -          Social:false, TabCrashHandler:false, TelemetryStopwatch:false,
> +          TabCrashHandler:false, TelemetryStopwatch:false,

You probably know it already, but bug 1388215 removed this comment.

::: browser/base/content/nsContextMenu.js:388
(Diff revision 3)
> -                    this.onImage || this.onVideo || this.onAudio || this.onSocial ||
> +                    this.onImage || this.onVideo || this.onAudio ||
>                      this.onCanvas || this.inWebExtBrowser));
>      bookmarkPage.setAttribute("tooltiptext", bookmarkPage.getAttribute("buttontooltiptext"));
>  
>      this.showItem("context-bookmarklink", (this.onLink && !this.onMailtoLink &&
> -                                           !this.onSocial && !this.onMozExtLink) ||
> +                                          !this.onMozExtLink) || this.onPlainTextLink);

nit: the indent is 1 space less than it should be on this line.
Does it mean that we should get rid of the Social API project on Pontoon?
https://github.com/mixedpuppy/socialapi-directory
(In reply to Francesco Lodolo [:flod] (traveling, slow reply until Aug 18) from comment #6)
> Does it mean that we should get rid of the Social API project on Pontoon?
> https://github.com/mixedpuppy/socialapi-directory

Yes, after this has landed.
Comment on attachment 8895580 [details]
Bug 1388902 remove socialapi share,

https://reviewboard.mozilla.org/r/166778/#review174480

Please remove the debugging code in:
caps/BasePrincipal.cpp 	
caps/nsScriptSecurityManager.cpp 	
docshell/base/nsDocShell.cpp 	
dom/security/nsContentSecurityManager.cpp 	
netwerk/base/SimpleChannelParent.cpp 	
netwerk/base/nsBaseChannel.cpp

Looks good otherwise :-)
Attachment #8895580 - Flags: review?(florian)
Comment on attachment 8895580 [details]
Bug 1388902 remove socialapi share,

https://reviewboard.mozilla.org/r/166778/#review174508

Thanks!
Attachment #8895580 - Flags: review?(florian) → review+
https://hg.mozilla.org/mozilla-central/rev/57e52be85a1a
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Release Note Request (optional, but appreciated)
[Why is this notable]: The "Share" button disappeared, and this is confusing for users who used this functionality. (cf. bug 1391311 comment 0)
[Affects Firefox for Android]: I don't know.
[Suggested wording]: The "Share" button was removed. You can now use the [page action menu](link to sumo) to quickly copy or email page links to people.

Note: this should be updated to refer to the explicit OS share functionality integration if/when bug 1363169 and friends get fixed.
[Links (documentation, blog post, etc)]: I don't have one. Maybe Shane wants to write one?
relnote-firefox: --- → ?
Flags: needinfo?(mixedpuppy)
I think it would be nice to have a migration path to webextensions so people won't be surprised or angry when 57 is out. Some have already noticed this on Nightly. Any plans?
I use that feature a lot (the share), I use privacy badger so I disabled everywhere the social buttons but in the browser are more comfortable (speed) but without a replacement I feel very abandoned.
It was only a popup with the share of every social network already filled with url and title.
There any plans for an extension?
This add-on was mentioned as having good share functionality: https://addons.mozilla.org/en-US/firefox/addon/addtoany-share/?src=search   I haven't tried it but you may want to give it a shot. There are probably others that add a share button to the browser. Hope that helps.
I tried that addon but with my permission about do not track, privacy badger and my /etc/hosts file that block websites that track etc whit extension doesn't work.
I have done an extension that reimplement the feature of the modal to share of Firefox share not available anymore on firefox nightly 57. Now we have only to wait the review :-)

https://addons.mozilla.org/it/firefox/addon/share-backported/
(In reply to Daniele "Mte90" Scasciafratte from comment #21)
> I have done an extension that reimplement the feature of the modal to share
> of Firefox share not available anymore on firefox nightly 57. Now we have
> only to wait the review :-)
> 
> https://addons.mozilla.org/it/firefox/addon/share-backported/

The extension is now published, thanks Daniele. We can propose this web extension as a migration path in the Nightly release notes.
[Affects Firefox for Android]: Firefox
[Suggested wording]: The "Share" button was removed. New extensions can implement share functionality using a page action.  Daniele Scasciafratte has provided a replacement extension at https://addons.mozilla.org/it/firefox/addon/share-backported/

Maybe something like that.
Flags: needinfo?(mixedpuppy)
In case, make sure to use a locale agnostic link https://addons.mozilla.org/firefox/addon/share-backported/
I have moved all the Social API documentation to the MDN archive:

https://developer.mozilla.org/en-US/docs/Archive/Social_API

I've also added a note to the Fx57 rel notes:

https://developer.mozilla.org/en-US/Firefox/Releases/57#APIs_2

Let me know if that's OK. Thanks!
Keywords: dev-doc-needed → dev-doc-complete
Sorry the 1st link should have been to mozilla-central:
https://dxr.mozilla.org/mozilla-central/source/modules/libpref/init/all.js#5226
Depends on: 1406193
new bugs for additional work please.
Flags: needinfo?(mixedpuppy)
Whiteboard: [tor 13612]
Blocks: 947535
Blocks: 1171247
Blocks: 1205165
Blocks: 1245658
Blocks: 1235973
Blocks: 1270274
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: