Open Bug 1388973 Opened 7 years ago Updated 7 months ago

Intermittent browser/base/content/test/general/browser_tab_dragdrop.js | Uncaught exception - TypeError: content.document.getElementById(...) is null

Categories

(Firefox :: Tabbed Browser, defect)

Product:
Firefox
Component:
Tabbed Browser
Type:
defect

Tracking

()

Tracking Flags:
Tracking Status
firefox61 --- disabled
firefox62 --- disabled
firefox70 --- fixed

People

(Reporter: intermittent-bug-filer, Unassigned)

References

Details

(Keywords: intermittent-failure, leave-open, Whiteboard: [stockwell disabled])

Attachments

(2 files, 3 obsolete files)

bug1388973.patch
924 bytes, patch
jmaher
: review+
Details | Diff | Splinter Review
Bug 1388973 - disabled test on all platforms r=jmaher
47 bytes, text/x-phabricator-request
Details | Review 
> This fail reached 34 failures in the last 7 days.
> I did some retriggers and it seems that it started from autoland with
> revision
> https://hg.mozilla.org/integration/autoland/rev/
> e561ff49b7cdd86d4cf437b98c986de76847f0dd
Blocks: 1454105
Flags: needinfo?(past) → needinfo?(mikokm)
(In reply to Narcis Beleuzu [:NarcisB] from comment #23)
> This fail reached 34 failures in the last 7 days.
> I did some retriggers and it seems that it started from autoland with
> revision
> https://hg.mozilla.org/integration/autoland/rev/
> e561ff49b7cdd86d4cf437b98c986de76847f0dd
> 
> Retriggers:
> https://treeherder.mozilla.org/#/jobs?repo=autoland&startdate=2018-04-
> 25&enddate=2018-04-26&filter-searchStr=opt-mochitest-browser-chrome-e10s-
> 14%20m-
> e10s(bc14)&tochange=ccfd7b716a91241ddbc084cb7116ec561e56d5d1&fromchange=20ffa
> afbae3c4f3c677ef12825207e4cf8fa5932&selectedJob=176228343
> 
> :past, can you please take a look?

This regression range seems wrong. I ran retriggers with these changesets backed out and the test still fails: https://treeherder.mozilla.org/#/jobs?repo=try&revision=154810b10721c624af4bfe102feb639f4494daa5
Flags: needinfo?(mikokm)
Attached patch disable_linux_osx_bug1388973 (obsolete) — — Splinter Review 

        Attachment #8973914 -
        Flags: review?(jmaher)

    
    

    
  
Comment on attachment 8973914 [details] [diff] [review]
disable_linux_osx_bug1388973

Review of attachment 8973914 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/test/general/browser.ini
@@ +435,4 @@
>  [browser_tab_drag_drop_perwindow.js]
>  # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
>  [browser_tab_dragdrop.js]
> +skip-if = buildapp == 'mulet' || (e10s && debug) || (os == 'linux' && !debug) || (os == 'osx' && !debug) # Bug 1312436, Bug 1388973

if you want bonus points, we do not do mulet builds anymore and we only run this test on e10s, so we could have changed the original skip-if to:
skip-if = debug

then adding in skipping osx/linux, it would be:
skip-if = debug || (os == "linux" || os == "osx") # ...

I will file a followup bug

        Attachment #8973914 -
        Flags: review?(jmaher) → review+
Keywords: checkin-needed, 
          
            leave-open
Whiteboard: [stockwell disable-recommended] → [stockwell disabled]

    
    

    
  


  
Assignee: nobody → dluca

        Attachment #8974047 -
        Flags: review?(jmaher)

    
    

    
  
Comment on attachment 8974047 [details] [diff] [review]
bug1388973 - Disabled on Linux and OSX

Review of attachment 8974047 [details] [diff] [review]:
-----------------------------------------------------------------

so close!

::: browser/base/content/test/general/browser.ini
@@ +435,4 @@
>  [browser_tab_drag_drop_perwindow.js]
>  # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
>  [browser_tab_dragdrop.js]
> +skip-if = debug || (os == 'linux') || (os == 'mac') # Bug 1312436, Bug 1388973 

nit: please remove the whitespace from the end of the line

        Attachment #8974047 -
        Flags: review?(jmaher) → review-

        Attachment #8973914 -
        Attachment is obsolete: true

    
    

    
  


  

        Attachment #8974047 -
        Attachment is obsolete: true

        Attachment #8974055 -
        Flags: review?(jmaher)

    
    

    
  
Comment on attachment 8974055 [details] [diff] [review]
bug1388973 - Disabled on Linux and OSX

Review of attachment 8974055 [details] [diff] [review]:
-----------------------------------------------------------------

perfect

        Attachment #8974055 -
        Flags: review?(jmaher) → review+

    
    

    
  
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9a9d2ff46ab7
Disable browser_tab_dragdrop.js on Linux and OSX. r=jmaher
Keywords: checkin-needed

    
    

    
  
Pushed by btara@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/42207baa6d08
Disabled browser_tab_dragdrop.js on Linux and OSX r=jmaher CLOSED TREE
Whiteboard: [stockwell disabled] → [stockwell disable-recommended]
Whiteboard: [stockwell disable-recommended] → [stockwell disabled]

    
  
No longer blocks: 1454105

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
  
There are 117 failures in the last 7 days.
Most of them are on windows10-64 /asan (115 failures).
From what I can see, the fail started to spike starting with https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=5e325e2cbb1695e9802de513b495406941c79621&selectedJob=194051866

Joel, this test was disabled on OSX and Linux. Should we disable it on Windows10 too?
Flags: needinfo?(jmaher)

    
    

    
      
  

    
    

    
  
yes, this is a very high failure rate, this is specifically windows 10 asan- in this case:
os == "win" && asan

Natalia, would you be able to pick this up on your shift?
Flags: needinfo?(jmaher) → needinfo?(ncsoregi)

    
    

    
  
(In reply to Joel Maher ( :jmaher ) (UTC-4) from comment #63)
> yes, this is a very high failure rate, this is specifically windows 10 asan-
> in this case:
> os == "win" && asan
> 
> Natalia, would you be able to pick this up on your shift?

yes, working on it
Flags: needinfo?(ncsoregi)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        bug1388973.patch
        — 
          — Splinter Review
      

    


  

        Attachment #8974055 -
        Attachment is obsolete: true

        Attachment #9003381 -
        Flags: review?(jmaher)

        Attachment #9003381 -
        Flags: review?(jmaher) → review+

    
    

    
  
Pushed by ebalazs@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a5f23c113987
Disabled browser_tab_dragdrop.js on Linux, OSX and Win10 asan.  r=jmaher
Keywords: checkin-needed

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
  
In the last 7 days, there have been 46 failures on windows7-32-shippable, windows10-64-qr, windows10-64-shippable-qr, windows10-64-shippable, windows10-aarch64 platforms, opt build type.


An example of a recent log file:

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=257693747&repo=autoland&lineNumber=2562


And the relevant part of the log:

14:36:47     INFO - TEST-PASS | browser/base/content/test/general/browser_tab_dragdrop.js | tab4 -

14:36:47     INFO - about to cacheObjectValue

14:36:47     INFO - Buffered messages finished

14:36:47     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_tab_dragdrop.js | Uncaught exception - TypeError: content.document.getElementById(...) is null

14:36:47     INFO - Leaving test bound

14:36:47     INFO - GECKO(5236) | MEMORY STAT | vsize 1023MB | vsizeMaxContiguous 503MB | residentFast 446MB | heapAllocated 221MB

14:36:47     INFO - TEST-OK | browser/base/content/test/general/browser_tab_dragdrop.js | took 414ms

14:36:47     INFO - Not taking screenshot here: see the one that was previously logged

14:36:47     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_tab_dragdrop.js | Found an unexpected tab at the end of test run: http://example.com/browser/browser/base/content/test/general/browser_tab_dragdrop_embed.html -

14:36:47     INFO - Not taking screenshot here: see the one that was previously logged

14:36:47     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_tab_dragdrop.js | Found an unexpected tab at the end of test run: data:text/plain;charset=utf-8,tab2 -

14:36:47     INFO - Not taking screenshot here: see the one that was previously logged

14:36:47     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_tab_dragdrop.js | Found an unexpected tab at the end of test run: data:text/html;charset=utf-8,<title>tab1</title><body>tab1<iframe> -

14:36:47     INFO - checking window state

14:36:47     INFO - GECKO(5236) | JavaScript error: resource://testing-common/PromiseTestUtils.jsm, line 112: uncaught exception: Object

14:36:47     INFO - TEST-START | browser/base/content/test/general/browser_tab_dragdrop2.js

14:36:47     INFO - GECKO(5236) | must wait for load


Justin, as you are the triage owner of this component, could you please take a look at this?

Thank you!


Flags: needinfo?(dolske)

    
    

    
      
  

    
    

    
  
Justin, did you get the chance to take a look at this?



    
    

    
      
  

    
    

    
  
There are 41 failures associated to this bug in the last 7 days. These are occurring on windows10-64-qr, windows10-64-shippable, windows10-64-shippable-qr, windows10-aarch64, windows7-32-shippable opt builds.


Any updates on this?



    
    

    
      
  

    
    

    
      
  

    
    

    
  
This bug failed 43 times in the last 7 days. Occurs on windows10-64-qr, windows10-64-shippable, windows10-64-shippable-qr, windows10-aarch64, windows7-32-shippable opt builds.


Recent log:

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=262198930&repo=mozilla-central&lineNumber=2518



    
    

    
      
  

    
    

    
      
  

        Attachment #9089052 -
        Attachment description: Bug 1388973 - update disabling condition to fully skip test on windows r?#intermittent-reviewers → Bug 1388973 - disabled test on all platforms r=jmaher

    
    

    
  
Pushed by rmaries@mozilla.com:

https://hg.mozilla.org/integration/autoland/rev/2fa81d89b660

disabled test on all platforms r=jmaher


Keywords: checkin-needed
Whiteboard: [stockwell disabled][stockwell needswork:owner] → [stockwell disabled]

    
    

    
      
  

    
    

    
      
  

    
    

    
  
The test looks like it is really to do with drag and drop of the tabbed browser, rather than just general. It should probably be moved into a better directory.


Moving this bug across to the tabbed browser component, and un-setting priority for triage - seeing as the test is fully disabled currently.


Assignee: dluca → nobody
Component: General → Tabbed Browser
Flags: needinfo?(dolske)
Priority: P5 → --

    
  
Severity: normal → S3
See Also:  → 1309420

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: