1389008 - Stop centering the tab label on Mac

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P1)

Description

[Dão Gottwald [:dao]]

As per https://mozilla.invisionapp.com/share/MRBK1MZF7#/screens/237333119

This makes tabs on Mac more consistent with other platforms.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1389008 - Stop centering the tab label on Mac.

Review commit: https://reviewboard.mozilla.org/r/167014/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/167014/

Comment 2

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8895713 [details]
Bug 1389008 - Stop centering the tab label on Mac.

https://reviewboard.mozilla.org/r/167014/#review172236

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0b60862b3898
Stop centering the tab label on Mac. r=nhnt11

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0b60862b3898

Comment 5

[Sören Hentzschel]

Out of pure curiosity as I liked the centered look *much more*: was there a reason to change the tab title alignment of macOS and not of the other platforms to make it centered on all platforms? As Chrome does it like Firefox now and Safari like Firefox before consistency across browsers cannot be the reason. Does it look better in the designer's opinion? Does it make something easier? The reason would just interest me. Thank you! :)

Comment 6

[Dão Gottwald [:dao]]

(In reply to Sören Hentzschel from comment #5)
> Out of pure curiosity as I liked the centered look *much more*: was there a
> reason to change the tab title alignment of macOS and not of the other
> platforms to make it centered on all platforms? As Chrome does it like
> Firefox now and Safari like Firefox before consistency across browsers
> cannot be the reason. Does it look better in the designer's opinion? Does it
> make something easier? The reason would just interest me. Thank you! :)

Comment 7

[Johann Hofmann [:johannh]]

Screenshots:

https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=5322c03f4c8587fe526172d3f87160031faa6d75&newProject=mozilla-central&newRev=d0068f9051be88eb4c97e28ec0a4f101ca4ff147&filter=osx

Comment 8

[Adolfo Jayme]

This should help unblocking the sliding text feature of bug 1352119.