1389023 - stylo: The interpolation of perspective transform is not correct

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P2)

Description

[Boris Chiou [:boris]]

In add_weighted_transform_lists [1], we convert a perspective function into a ComputedMatrix, but we apply the perspective length to a wrong matrix item. We should put it into m34, instead of m43. m43 is for translate parameter Z [2].

[1] http://searchfox.org/mozilla-central/rev/c329d562fb6c6218bdb79290faaf015467ef89e2/servo/components/style/properties/helpers/animated_properties.mako.rs#1732-1733
[2] https://www.w3.org/TR/css-transforms-1/#PerspectiveDefined

Comment 1

[Boris Chiou [:boris]]

Attachment: Bug 1389023 - Fix the conversion from Perspective into ComputedMatrix.

Review commit: https://reviewboard.mozilla.org/r/167086/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/167086/

Comment 2

[Boris Chiou [:boris]]

Comment on attachment 8895756 [details]
Bug 1389023 - Fix the conversion from Perspective into ComputedMatrix.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/167086/diff/1-2/

Comment 3

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Comment on attachment 8895756 [details]
Bug 1389023 - Fix the conversion from Perspective into ComputedMatrix.

https://reviewboard.mozilla.org/r/167086/#review173198

Comment 4

[Boris Chiou [:boris]]

Attachment: Servo PR, #18068

Comment 5

[Ekanan Ketunuti]

https://hg.mozilla.org/mozilla-central/rev/9c9e455241e5