1389446 - Poor contrast in the add-ons page

Status: RESOLVED DUPLICATE of bug 1388761

(Firefox :: Theme, defect)

Description

[Michał Gołębiowski-Owczarek [:mgol]]

Attachment: add-ons page screenshot

A few days ago contrast of the left sidebar on the add-ons page got way worse, I'm convinced this is an accessibility issue.

See the attached screenshot done on a fresh profile.

Comment 1

[Michał Gołębiowski-Owczarek [:mgol]]

This is on latest macOS Sierra 10.12.6 (16G29), BTW.

Comment 2

[:Gijs (he/him)]

Moving this to Fx::Theme as the issue is not specific to being accessibility-related but adding the access keyword to keep this on the a11y radar. The current styling doesn't look intentional to me. Can you try using mozregression to find out when this broke? ( https://mozilla.github.io/mozregression/ ).

Comment 3

[:Gijs (he/him)]

http://webaim.org/resources/contrastchecker/ suggests the contrast ratio is 2.33:1 which fails AA and AAA checks for both small and large text, so it's clear that the contrast is objectively not good enough by a significant margin.

Comment 4

[Michał Gołębiowski-Owczarek [:mgol]]

I haven't used mozregression before, a really nice tool!

It ended up with:
Last good revision: 2b587b20717b27cd25686a410fee63cf7538cccc
First bad revision: 0d1ee6f3b3f40d9e4bbc36403c68684a2038654e

Comment 5

[Michał Gołębiowski-Owczarek [:mgol]]

Also, the last line of the output:

Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2b587b20717b27cd25686a410fee63cf7538cccc&tochange=0d1ee6f3b3f40d9e4bbc36403c68684a2038654e

Comment 6

[:Gijs (he/him)]

Looks like this was caused by bug 1361957 but is fixed on today's nightly, due to bug 1388761. :-)