1389907 - Unable to remove form history entries by mouse-hover

Status: RESOLVED DUPLICATE of bug 1412510

(Toolkit :: Form Manager, defect, P3)

Description

[[:philipp]]

Attachment: screenshot.png

since firefox 55 it's no longer possible to delete an entry showing up in the form fill dropdown for textfields on websites by hovering over it with the mouse and pressing the del key.

if you hover over an entry it's staying greyed out - if you want to actually delete an entry you now have to keep the mouse button pressed to get it selected (selection turns from grey to blue then - at least that's how it is on windows) and hit del at the same time.

this is regressing with bug 1357533 - i'm not sure if this is an intentional by-product from this bug or not.

Comment 1

[Mike Taylor [:miketaylr]]

Philipp, Bug 1357533 hasn't landed yet, is that a typo?

Comment 2

[[:philipp]]

yes sorry, that was a mistake - the actual bug introducing the problem when regression-testing the issue is bug 1295458 instead:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=64ba6efd97222a83c08d56f0f2e772aec688ec8c&tochange=bb0c3ac257626ab547739bdd8ea6e2ef915f9017

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

Stephen, bug 1295458 was about the awesomebar, but unfortunately it shares code with other autocomplete input fields. It seems expected to me that removing an awesomebar autocomplete entry would now require navigating to the entry via keyboard and hitting delete. Do you think we should fix this for other autocomplete fields? How much should the behavior deviate between them?

Comment 4

[Matthew N. [:MattN]]

Still waiting on shorlander here to know next steps.

Comment 5

[Stephen Horlander [:shorlander]]

(In reply to Panos Astithas [:past] (please ni?) from comment #3)
> Stephen, bug 1295458 was about the awesomebar, but unfortunately it shares
> code with other autocomplete input fields. It seems expected to me that
> removing an awesomebar autocomplete entry would now require navigating to
> the entry via keyboard and hitting delete. Do you think we should fix this
> for other autocomplete fields? How much should the behavior deviate between
> them?

While this was not an intentional change as part of that bug, I think it is the right behavior. Actions on items typically require the item to be selected or focused and not just hovered.

FWIW this behavior in general is unusual. Transient list items in form autocomplete pop-ups aren't usually managed (e.g. edited, deleted) directly via key press. It's also completely hidden because we don't surface UI for it and it's possible to accidentally delete something.

Comment 6

[Caspy7]

As a data reference point, here is a user who was frustrated because they were unable to delete form items. It was their apparent understanding that highlighting them with mouse hover was sufficient to select them.

https://twitter.com/Dales_Starman/status/1016946023997083649