Closed Bug 1390049 Opened 7 years ago Closed 7 years ago

Fix the "Settings" button string under Permissions in about:preferences#privacy by appending ellipses

Categories

(Firefox :: Settings UI, defect, P1)

Product:
Firefox
Component:
Settings UI
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 57
Tracking Flags:
Tracking Status
firefox57 --- verified

People

(Reporter: prathiksha, Assigned: prathiksha)

References

Details

(Whiteboard: [photon-preference])

Attachments

(1 file)

Bug 1390049 - Fix the Settings button string under Permissions in about:preferences#privacy by appending ellipses.
59 bytes, text/x-review-board-request
rickychien
: review+
Details
Assignee: nobody → prathikshaprasadsuman
Comment on attachment 8896879 [details]
Bug 1390049 - Fix the Settings button string under Permissions in about:preferences#privacy by appending ellipses.

https://reviewboard.mozilla.org/r/168168/#review173328

LGTM. Thanks:)
Attachment #8896879 - Flags: review?(rchien) → review+
Flags: qe-verify+
QA Contact: hani.yacoub
Whiteboard: [photon-preference][triage]
Keywords: checkin-needed
Pushed by rchien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f011eb6ab266
Fix the Settings button string under Permissions in about:preferences#privacy by appending ellipses. r=rickychien
Keywords: checkin-needed
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/f011eb6ab266
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Whiteboard: [photon-preference][triage] → [photon-preference]
I'm trying to verify this bug on Nightly 57 but I can't figure out what is the expected behavior here.
Could you please provide me with the expected behavior?

Thanks.
Flags: needinfo?(prathikshaprasadsuman)
Expected behavior - The 'Settings' buttons label in about:preferences#privacy under the 'Permissions' heading should be "Settings...". 

The label was "Settings" initially and was changed to "Settings..." with the ellipses.
Flags: needinfo?(prathikshaprasadsuman)
Build ID: 20170816100153
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0

Verified as fixed on Firefox Nightly 57.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.
Status: RESOLVED → VERIFIED
status-firefox57: fixed → verified
Priority: -- → P1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: