Closed
Bug 1390147
Opened 7 years ago
Closed 7 years ago
Remove getProperty Class hook from StatementJSHelper and AsyncStatementJSHelper
Categories
(Toolkit :: Storage, enhancement)
Toolkit
Storage
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(1 file)
|
6.11 KB,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
We want to remove these ClassOps, see bug 1389510. There's more to do for storage/ but these *StatementJSHelper ones are easy to fix. In bug 1389510 comment 3 bz mentioned we could remove these JSHelper classes completely and use IDL for the "params" and "row" properties. That's a lot more complicated though - the easiest fix is to replace the getProperty hook with a resolve hook that defines the property.
Attachment #8896982 -
Flags: review?(mrbkap)
|
||
Comment 1•7 years ago
|
||
Comment on attachment 8896982 [details] [diff] [review] Patch Please do file follow bugs on getting rid of these scriptable helpers.
Attachment #8896982 -
Flags: review?(mrbkap) → review+
Pushed by jandemooij@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/35622c347169 Remove getProperty Class hook from StatementJSHelper and AsyncStatementJSHelper. r=mrbkap
|
Assignee | |
Comment 3•7 years ago
|
||
(In reply to Blake Kaplan (:mrbkap) from comment #1) > Please do file follow bugs on getting rid of these scriptable helpers. Filed bug 1390528.
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/35622c347169
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•