1390176 - Increase console logLimit

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Description

[Brian Grinstead [:bgrins]]

As a way to make Bug 1386289 less likely, we should bump up the default log limit from 1000

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: Bug 1390176 - Fix the jsterm stub in test_render_perf;

Review commit: https://reviewboard.mozilla.org/r/168324/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/168324/

Comment 2

[Brian Grinstead [:bgrins]]

Attachment: Bug 1390176 - Increase console logLimit;

Review commit: https://reviewboard.mozilla.org/r/168330/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/168330/

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8897041 [details]
Bug 1390176 - Increase console logLimit;

https://reviewboard.mozilla.org/r/168330/#review174368

Should we change it in http://searchfox.org/mozilla-central/rev/13148faaa91a1c823a7d68563d9995480e714979/devtools/client/webconsole/local-dev/index.js#31 too ?

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8897040 [details]
Bug 1390176 - Fix the jsterm stub in test_render_perf;

https://reviewboard.mozilla.org/r/168324/#review174372

::: devtools/client/webconsole/new-console-output/test/chrome/test_render_perf.html:22
(Diff revision 1)
>  
>  // To analyze the profile results:
>  // > ./mach mochitest test_render_perf.html
>  // Then open https://perf-html.io and drag the json file printed at the end of this test
>  
>  const NUM_MESSAGES = 4000;

Should we change that as well (to 14000) ?
This way we still test how much it cost to have more messages than the console displays.

Comment 5

[Brian Grinstead [:bgrins]]

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #4)
> Comment on attachment 8897040 [details]
> Bug 1390176 - Fix the jsterm stub in test_render_perf;
> 
> https://reviewboard.mozilla.org/r/168324/#review174372
> 
> :::
> devtools/client/webconsole/new-console-output/test/chrome/test_render_perf.
> html:22
> (Diff revision 1)
> >  
> >  // To analyze the profile results:
> >  // > ./mach mochitest test_render_perf.html
> >  // Then open https://perf-html.io and drag the json file printed at the end of this test
> >  
> >  const NUM_MESSAGES = 4000;
> 
> Should we change that as well (to 14000) ?
> This way we still test how much it cost to have more messages than the
> console displays.

I tried this originally, but the slowness is relatively linear so we get similar information with the smaller number and the test finishes much more quickly.

Comment 6

[Brian Grinstead [:bgrins]]

Comment on attachment 8897040 [details]
Bug 1390176 - Fix the jsterm stub in test_render_perf;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/168324/diff/1-2/

Comment 7

[Brian Grinstead [:bgrins]]

Comment on attachment 8897041 [details]
Bug 1390176 - Increase console logLimit;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/168330/diff/1-2/

Comment 8

[Brian Grinstead [:bgrins]]

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #3)
> Comment on attachment 8897041 [details]
> Bug 1390176 - Increase console logLimit;
> 
> https://reviewboard.mozilla.org/r/168330/#review174368
> 
> Should we change it in
> http://searchfox.org/mozilla-central/rev/
> 13148faaa91a1c823a7d68563d9995480e714979/devtools/client/webconsole/local-
> dev/index.js#31 too ?

Yes, good catch

Comment 9

[Brian Grinstead [:bgrins]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=395656eb2734777e048ed6ab3220718fd20a2087

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/17f391c7458c
Fix the jsterm stub in test_render_perf;r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/9a32af020333
Increase console logLimit;r=nchevobbe

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/17f391c7458c
https://hg.mozilla.org/mozilla-central/rev/9a32af020333