Closed
Bug 1390396
Opened 7 years ago
Closed 7 years ago
Reenable mochitests for custom elements lifecycle callbacks
Categories
(Core :: DOM: Core & HTML, enhancement, P2)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla59
People
(Reporter: jessica, Assigned: edgar)
References
Details
Attachments
(1 file)
We will disable some of the custom element v0-compatible mochitests while implementing v1 lifecycle callbacks. We should reenable them once v1 lifecycle callbacks are completed and change them to v1-compatible.
Updated•7 years ago
|
Priority: -- → P2
Assignee | ||
Comment 1•7 years ago
|
||
v1 lifecycle callbacks are all landed, I think it's time to change disabled mochitests to v1-compatible and reenable them.
Assignee: nobody → echen
Assignee | ||
Comment 2•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6727940c8852c839ac330629aee85e47d25cb57d&filter-tier=1&group_state=expanded
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8928780 -
Flags: feedback?(jdai)
Comment hidden (mozreview-request) |
Assignee | ||
Comment 6•7 years ago
|
||
Comment on attachment 8928780 [details] Bug 1390396 - Reenable mochitests for custom elements lifecycle callbacks; I found there is a typo in the previous version, send feedback request again for the new version which fixes the typo.
Attachment #8928780 -
Flags: feedback?(jdai)
Comment 7•7 years ago
|
||
Comment on attachment 8928780 [details] Bug 1390396 - Reenable mochitests for custom elements lifecycle callbacks; Looks good to me.
Attachment #8928780 -
Flags: feedback?(jdai) → feedback+
Assignee | ||
Comment 8•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a444b69bba88&group_state=expanded&filter-tier=1
Assignee | ||
Updated•7 years ago
|
Attachment #8928780 -
Flags: review?(bugs)
Comment 9•7 years ago
|
||
mozreview-review |
Comment on attachment 8928780 [details] Bug 1390396 - Reenable mochitests for custom elements lifecycle callbacks; https://reviewboard.mozilla.org/r/200048/#review207338
Attachment #8928780 -
Flags: review?(bugs) → review+
Comment 10•7 years ago
|
||
Pushed by echen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b4a1ab50128e Reenable mochitests for custom elements lifecycle callbacks; r=smaug
Comment 11•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b4a1ab50128e
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Updated•7 years ago
|
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•