Closed Bug 1390503 Opened 7 years ago Closed 7 years ago

Retry without the fast open on NS_ERROR_FAILURE

Categories

(Core :: Networking: HTTP, defect)

57 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: dragana, Assigned: dragana)

References

Details

(Whiteboard: [necko-active])

Attachments

(1 file)

In waiting for bug 1386719 to be reviewd by a nspr peer, I made a work around for it in bug 1389079 that retries connection if ContinueConnect returns NS_ERROR_FAILURE.

I forgot to add this error to the list in SetFastOpenConnected :(
Attachment #8897417 - Flags: review?(mcmanus)
Attachment #8897417 - Flags: review?(mcmanus) → review+
Pushed by dd.mozilla@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/996189aa5b6f
Retry without fast open if error is NS_ERROR_FAILURE. r=mcmanus
I see a talos improvement from this landing:
== Change summary for alert #8797 (as of August 15 2017 17:38 UTC) ==

Improvements:

 19%  sessionrestore_many_windows windows10-64 pgo e10s     4,649.83 -> 3,783.67

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=8797
https://hg.mozilla.org/mozilla-central/rev/996189aa5b6f
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: