1390706 - Remove Flash CTP rollout addon and make it CTP by default through prefs

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, enhancement)

Description

[:Felipe Gomes (needinfo for replies!)]

+++ This bug was initially created as a clone of Bug #1390705 +++

After bug 1390705 sticks properly on release (making Flash 100% CTP), we should fully remove the clicktoplay-rollout system addon from the tree, and just toggle the pref by default on all channels.

Comment 1

[:Felipe Gomes (needinfo for replies!)]

Attachment: Bug 1390706 - Remove Flash CTP rollout addon and make it CTP by default through prefs.

Review commit: https://reviewboard.mozilla.org/r/168934/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/168934/

Comment 2

[Benjamin Smedberg]

Comment on attachment 8897656 [details]
Bug 1390706 - Remove Flash CTP rollout addon and make it CTP by default through prefs.

https://reviewboard.mozilla.org/r/168934/#review174486

I think we should land this to nightly immediately. I was going to say we should also uplift to beta now, but RT might want to wait a few weeks just to make sure release rollout is going ok. But for 57 we know we're going to ship this regardless.

Comment 3

[:Felipe Gomes (needinfo for replies!)]

Now that we've gone to 100% on 56 (bug 1390705), we can remove the system add-on for 57 and just set this through prefs.

This should be a perf win because Florian noted that he frequently saw this system addon while he was profiling startup times.

Comment 4

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s a0d97ba08143 -d 847a0c0530a5: rebasing 421366:a0d97ba08143 "Bug 1390706 - Remove Flash CTP rollout addon and make it CTP by default through prefs. r=benjamin+7044" (tip)
local [dest] changed browser/extensions/clicktoplay-rollout/bootstrap.js which other [source] deleted
use (c)hanged version, (d)elete, or leave (u)nresolved? u
local [dest] changed browser/extensions/clicktoplay-rollout/moz.build which other [source] deleted
use (c)hanged version, (d)elete, or leave (u)nresolved? u
merging browser/app/profile/firefox.js
merging browser/extensions/moz.build
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 5

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8897656 [details]
Bug 1390706 - Remove Flash CTP rollout addon and make it CTP by default through prefs.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/168934/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a6f36a2ff650
Remove Flash CTP rollout addon and make it CTP by default through prefs. r=benjamin+7044

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/a6f36a2ff650

Comment 8

[Jim Jeffery not reading bug-mail 1/2/11]

I just installed latest win32 m-c build cset: https://hg.mozilla.org/mozilla-central/rev/a20de99fa3c1ba6287fe47d493a859a4e95120b0

Checking about:support -> Looking at Nightly Features - Click to play staged rollout is still shown in list.

Mozilla/5.0 (Windows NT 10.0; WOW64; rv:57.0) Gecko/20100101 Firefox/57.0

Comment 9

[Jim Jeffery not reading bug-mail 1/2/11]

I manually removed the xpi from the 'features' folder - was this patch supposed to already do that ?  Seems it was removed from talos and build but not the browser ?

I'm not good at reading patches - but seems to me that the xpi should have been removed.

Comment 10

[:Felipe Gomes (needinfo for replies!)]

Hmm it was supposed to remove it.. rhelmer, is there anything else that needs to be done to remove a system addon?

Comment 11

[:Felipe Gomes (needinfo for replies!)]

FWIW, it disappeared automatically on my Nightly. Are you sure that the build you tested already included this changeset?

Comment 12

[Jim Jeffery not reading bug-mail 1/2/11]

(In reply to :Felipe Gomes (needinfo me!) [offline Sep-20 to Oct-1] from comment #11)
> FWIW, it disappeared automatically on my Nightly. Are you sure that the
> build you tested already included this changeset?

Yes I'm absolutely sure. Note the cset in comment #8 showing the tested build.

Comment 13

[Jim Jeffery not reading bug-mail 1/2/11]

OK, I restored the file from the Windows 'trash-bin', removed Nighed through add/remove and installed a newer build than stated above, and the file was indeed removed.  

No Idea what might have happened.  Sorry for the 'Noise'.

Comment 14

[Jim Jeffery not reading bug-mail 1/2/11]

(In reply to :Felipe Gomes (needinfo me!) [offline Sep-20 to Oct-1] from comment #11)
> FWIW, it disappeared automatically on my Nightly. Are you sure that the
> build you tested already included this changeset?

Needinfo did not clear out.. see comment #13 - issue is resolved.

Comment 15

[Jim Jeffery not reading bug-mail 1/2/11]

OK, I restored the file from the Windows 'trash-bin', removed Nighed through add/remove and installed a newer build than stated above, and the file was indeed removed.  

No Idea what might have happened.  Sorry for the 'Noise'.