Closed
Bug 1390822
Opened 7 years ago
Closed 7 years ago
Gecko-side strings (Strings.browser.GetStringFromName) aren't updated after a locale change
Categories
(Firefox for Android Graveyard :: Locale switching and selection, defect)
Tracking
(fennec+, firefox-esr52 unaffected, firefox55 wontfix, firefox56 verified, firefox57 verified)
VERIFIED
FIXED
Firefox 57
Tracking | Status | |
---|---|---|
fennec | + | --- |
firefox-esr52 | --- | unaffected |
firefox55 | --- | wontfix |
firefox56 | --- | verified |
firefox57 | --- | verified |
People
(Reporter: Virtual, Assigned: zbraniecki)
References
Details
(Keywords: nightly-community, regression, Whiteboard: [fixed by patch from bug #1378501])
Attachments
(1 file)
59 bytes,
text/x-review-board-request
|
Details |
STR: 1. Start Mozilla Firefox Mobile 2. Press "Hamburger" button 3. Press "Settings" item in Hamburger menu 4. Press "Privacy" item in Settings menu 5. Enable "Clear private data on exit" 6. and select everything in next menu, except "Downloads" item 7. Press "SET" 8. Pres <- ("Back") button to go to Settings menu 9. Press "Genera" item in Settings menu 10. Press "Language" item in General menu 11. Select "English (United States)" language 12. Pres <- ("Back") button to go to General menu 13. Pres <- ("Back") button to go to Settings menu 14. Pres <- ("Back") button to go to Firefox tabs 15. Press "Hamburger" button 16. Press "Quit" item in hamburger menu and see that "Clearing private data..." information is showing as localized one "Czyszczenie prywatnych danych...". Changing Android language from Polish to English (Unite States) doesn't change anything. Mozilla Firefox Mobile 55.0 on Android 6.0.1
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•7 years ago
|
Has STR: --- → yes
QA Contact: Virtual
Comment 1•7 years ago
|
||
It looks like Strings.browser.GetStringFromName continues returning whatever locale was initially selected during the browsing session, at least for things handled by our JS chrome code, because this also affects our context menus, the various messages when opening/closing tabs, etc. Things like about:addons, about:firefox, our error messages on the other hand correct themselves after a reload (maybe that's a clue - we don't "reload" our UI code after a locale change), although interestingly enough the preinstalled H264 codec in about:addons continues being localised in whatever locale was initially active even after a reload of about:addons.
Hardware: ARM → All
Summary: "Clearing private data..." is showing as localized one instead of in language selected in Mozilla Firefox Mobile settings → Gecko-side strings (Strings.browser.GetStringFromName) aren't updated after a locale change
Comment 2•7 years ago
|
||
Hi Jan Nice catch! Do you think we should restart the app when there's a configuration change? Hi snorp Is there a way for Gecko to re-load the locale string?
Flags: needinfo?(snorp)
Flags: needinfo?(jh+bugzilla)
Comment 3•7 years ago
|
||
No, we should fix Strings.browser.GetStringFromName to work properly. I haven't looked how far back this problem goes, but maybe it's still some fallout from the relatively recent-ish locale system changes that also caused some other bugs.
Flags: needinfo?(jh+bugzilla) → needinfo?(gandalf)
Richard may have some info here too
tracking-fennec: ? → +
status-firefox55:
--- → fix-optional
status-firefox56:
--- → affected
status-firefox57:
--- → affected
Flags: needinfo?(snorp) → needinfo?(rnewman)
Comment 5•7 years ago
|
||
(In reply to Jan Henning [:JanH] from comment #3) > No, we should fix Strings.browser.GetStringFromName to work properly. I > haven't looked how far back this problem goes, but maybe it's still some > fallout from the relatively recent-ish locale system changes that also > caused some other bugs. I don't know if anyone ever tested locale switching with the clear private data on exit code flow. browser.js uses thunks to accommodate dynamic locale changes: initContextMenu: function () { // We pass a thunk in place of a raw label string. This allows the // context menu to automatically accommodate locale changes without // having to be rebuilt. let stringGetter = name => () => Strings.browser.GetStringFromName(name); // TODO: These should eventually move into more appropriate classes NativeWindow.contextmenus.add(stringGetter("contextmenu.openInNewTab"), and that _was_ tested: our context menus, last I was involved with Fennec, correctly reflected changes in in-app locale. If they're no longer doing so, then it seems that somebody regressed GSFN, perhaps in a bug like Bug 1351873. Gandalf is the right person to ask.
Flags: needinfo?(rnewman)
Assignee | ||
Comment 6•7 years ago
|
||
Yep, I'll be debugging this tomorrow.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → gandalf
Status: NEW → ASSIGNED
Flags: needinfo?(gandalf)
Comment hidden (mozreview-request) |
Assignee | ||
Comment 8•7 years ago
|
||
I regressed it in bug 1346617. Bringing back the flush fixes this issue.
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•7 years ago
|
Blocks: 1346617
Has Regression Range: --- → yes
status-firefox-esr52:
--- → unaffected
Keywords: regression
Comment 9•7 years ago
|
||
I have the one-line fix for this in my patch for Bug 1378501. Waiting on hg account reactivation so I can push.
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•7 years ago
|
Depends on: 1378501
Comment 10•7 years ago
|
||
Fixed in Bug 1378501.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•7 years ago
|
Blocks: 1398209
Status: RESOLVED → VERIFIED
Resolution: DUPLICATE → FIXED
Whiteboard: [fixed by patch from bug #1378501]
Target Milestone: --- → Firefox 57
Updated•7 years ago
|
Attachment #8905678 -
Flags: review?(rnewman)
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•