1390847 - Deprecate update_crash_adu_by_build_signature

Status: RESOLVED FIXED

(Socorro :: General, task)

Description

[Peter Bengtsson [:peterbe]]

As of https://bugzilla.mozilla.org/show_bug.cgi?id=1380761 there is no way to reach the data in the `crash_adu_by_build_signature` table. 

This table is fed by a crontabber app [0] which calls a stored procedure [1] that populates the table.

This bug is about removing both of these. 

Once #1380761 lands we'll remove crontabber app update-crash-adu-by-build-signature from configuration (and default list [2]) and once that's done, we'll go ahead and delete the crontabber app. Lastly we'll remove the table and the stored procedure. 

[0] https://github.com/mozilla-services/socorro/blob/a40a047abbc776fa205561f6ce8fc863a8d0f803/socorro/cron/jobs/matviews.py#L122
[1] https://github.com/mozilla-services/socorro/blob/a40a047abbc776fa205561f6ce8fc863a8d0f803/socorro/external/postgresql/raw_sql/procs/update_crash_adu_by_build_signature.sql#L1
[2] https://github.com/mozilla-services/socorro/blob/a40a047abbc776fa205561f6ce8fc863a8d0f803/socorro/cron/crontabber_app.py#L22

Comment 1

[Peter Bengtsson [:peterbe]]

From from jobs in stage.

BEFORE:
socorro.cron.jobs.weekly_reports_partitions.WeeklyReportsPartitionsCronApp|7d, socorro.cron.jobs.matviews.ProductVersionsCronApp|1d|05:00, socorro.cron.jobs.matviews.SignaturesCronApp|1d|05:00, socorro.cron.jobs.matviews.RawUpdateChannelCronApp|1d|05:00, socorro.cron.jobs.matviews.ADUCronApp|1d|08:30, socorro.cron.jobs.matviews.DuplicatesCronApp|1h, socorro.cron.jobs.matviews.ReportsCleanCronApp|1h, socorro.cron.jobs.bugzilla.BugzillaCronApp|1h, socorro.cron.jobs.matviews.BuildADUCronApp|1d|08:30, socorro.cron.jobs.matviews.AndroidDevicesCronApp|1d|05:00, socorro.cron.jobs.matviews.GraphicsDeviceCronApp|1d|05:00, socorro.cron.jobs.matviews.CrashAduByBuildSignatureCronApp|1d|08:30, socorro.cron.jobs.ftpscraper.FTPScraperCronApp|1h, socorro.cron.jobs.elasticsearch_cleanup.ElasticsearchCleanupCronApp|7d, socorro.cron.jobs.drop_old_partitions.DropOldPartitionsCronApp|7d, socorro.cron.jobs.truncate_partitions.TruncatePartitionsCronApp|7d, socorro.cron.jobs.featured_versions_automatic.FeaturedVersionsAutomaticCronApp|1h, socorro.cron.jobs.clean_raw_adi_logs.CleanRawADILogsCronApp|1d, socorro.cron.jobs.clean_raw_adi.CleanRawADICronApp|1d, socorro.cron.jobs.fetch_adi_from_hive.FAKEFetchADIFromHiveCronApp|1d, socorro.cron.jobs.clean_missing_symbols.CleanMissingSymbolsCronApp|1d, socorro.cron.jobs.missingsymbols.MissingSymbolsCronApp|1d, socorro.cron.jobs.upload_crash_report_json_schema.UploadCrashReportJSONSchemaCronApp|1h

AFTER:
socorro.cron.jobs.weekly_reports_partitions.WeeklyReportsPartitionsCronApp|7d, socorro.cron.jobs.matviews.ProductVersionsCronApp|1d|05:00, socorro.cron.jobs.matviews.SignaturesCronApp|1d|05:00, socorro.cron.jobs.matviews.RawUpdateChannelCronApp|1d|05:00, socorro.cron.jobs.matviews.ADUCronApp|1d|08:30, socorro.cron.jobs.matviews.DuplicatesCronApp|1h, socorro.cron.jobs.matviews.ReportsCleanCronApp|1h, socorro.cron.jobs.bugzilla.BugzillaCronApp|1h, socorro.cron.jobs.matviews.BuildADUCronApp|1d|08:30, socorro.cron.jobs.matviews.AndroidDevicesCronApp|1d|05:00, socorro.cron.jobs.matviews.GraphicsDeviceCronApp|1d|05:00, socorro.cron.jobs.ftpscraper.FTPScraperCronApp|1h, socorro.cron.jobs.elasticsearch_cleanup.ElasticsearchCleanupCronApp|7d, socorro.cron.jobs.drop_old_partitions.DropOldPartitionsCronApp|7d, socorro.cron.jobs.truncate_partitions.TruncatePartitionsCronApp|7d, socorro.cron.jobs.featured_versions_automatic.FeaturedVersionsAutomaticCronApp|1h, socorro.cron.jobs.clean_raw_adi_logs.CleanRawADILogsCronApp|1d, socorro.cron.jobs.clean_raw_adi.CleanRawADICronApp|1d, socorro.cron.jobs.fetch_adi_from_hive.FAKEFetchADIFromHiveCronApp|1d, socorro.cron.jobs.clean_missing_symbols.CleanMissingSymbolsCronApp|1d, socorro.cron.jobs.missingsymbols.MissingSymbolsCronApp|1d, socorro.cron.jobs.upload_crash_report_json_schema.UploadCrashReportJSONSchemaCronApp|1h


Basically, it removed `socorro.cron.jobs.matviews.CrashAduByBuildSignatureCronApp|1d|08:30`

Comment 2

[Peter Bengtsson [:peterbe]]

Note-to-self; Now that the crontabber app has been disabled from stage admin, let it be like that for a while to assert that we don't depend on that data some elsewhere. Once that's done, remove it from the list of ``jobs`` on prod admin too. 
Then, proceed and make a PR that removes the python code (and mention in list of default crontabber apps).

Comment 3

[Peter Bengtsson [:peterbe]]

From the jobs in -prod. 

BEFORE:
socorro.cron.jobs.weekly_reports_partitions.WeeklyReportsPartitionsCronApp|7d, socorro.cron.jobs.matviews.ProductVersionsCronApp|1d|05:00, socorro.cron.jobs.matviews.SignaturesCronApp|1d|05:00, socorro.cron.jobs.matviews.RawUpdateChannelCronApp|1d|05:00, socorro.cron.jobs.matviews.ADUCronApp|1d|08:30, socorro.cron.jobs.matviews.DuplicatesCronApp|1h, socorro.cron.jobs.matviews.ReportsCleanCronApp|1h, socorro.cron.jobs.bugzilla.BugzillaCronApp|1h, socorro.cron.jobs.matviews.BuildADUCronApp|1d|08:30, socorro.cron.jobs.matviews.AndroidDevicesCronApp|1d|05:00, socorro.cron.jobs.matviews.GraphicsDeviceCronApp|1d|05:00, socorro.cron.jobs.matviews.CrashAduByBuildSignatureCronApp|1d|08:30, socorro.cron.jobs.ftpscraper.FTPScraperCronApp|1h, socorro.cron.jobs.elasticsearch_cleanup.ElasticsearchCleanupCronApp|7d, socorro.cron.jobs.drop_old_partitions.DropOldPartitionsCronApp|7d, socorro.cron.jobs.truncate_partitions.TruncatePartitionsCronApp|7d, socorro.cron.jobs.clean_raw_adi_logs.CleanRawADILogsCronApp|1d, socorro.cron.jobs.clean_raw_adi.CleanRawADICronApp|1d, socorro.cron.jobs.clean_missing_symbols.CleanMissingSymbolsCronApp|1d, socorro.cron.jobs.missingsymbols.MissingSymbolsCronApp|1d, socorro.cron.jobs.featured_versions_automatic.FeaturedVersionsAutomaticCronApp|1h, socorro.cron.jobs.upload_crash_report_json_schema.UploadCrashReportJSONSchemaCronApp|1h


AFTER:
socorro.cron.jobs.weekly_reports_partitions.WeeklyReportsPartitionsCronApp|7d, socorro.cron.jobs.matviews.ProductVersionsCronApp|1d|05:00, socorro.cron.jobs.matviews.SignaturesCronApp|1d|05:00, socorro.cron.jobs.matviews.RawUpdateChannelCronApp|1d|05:00, socorro.cron.jobs.matviews.ADUCronApp|1d|08:30, socorro.cron.jobs.matviews.DuplicatesCronApp|1h, socorro.cron.jobs.matviews.ReportsCleanCronApp|1h, socorro.cron.jobs.bugzilla.BugzillaCronApp|1h, socorro.cron.jobs.matviews.BuildADUCronApp|1d|08:30, socorro.cron.jobs.matviews.AndroidDevicesCronApp|1d|05:00, socorro.cron.jobs.matviews.GraphicsDeviceCronApp|1d|05:00, socorro.cron.jobs.ftpscraper.FTPScraperCronApp|1h, socorro.cron.jobs.elasticsearch_cleanup.ElasticsearchCleanupCronApp|7d, socorro.cron.jobs.drop_old_partitions.DropOldPartitionsCronApp|7d, socorro.cron.jobs.truncate_partitions.TruncatePartitionsCronApp|7d, socorro.cron.jobs.clean_raw_adi_logs.CleanRawADILogsCronApp|1d, socorro.cron.jobs.clean_raw_adi.CleanRawADICronApp|1d, socorro.cron.jobs.clean_missing_symbols.CleanMissingSymbolsCronApp|1d, socorro.cron.jobs.missingsymbols.MissingSymbolsCronApp|1d, socorro.cron.jobs.featured_versions_automatic.FeaturedVersionsAutomaticCronApp|1h, socorro.cron.jobs.upload_crash_report_json_schema.UploadCrashReportJSONSchemaCronApp|1h


Basically, I removed the "socorro.cron.jobs.matviews.CrashAduByBuildSignatureCronApp|1d|08:30" bit.

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/ea65d860cf0c205ed030f27a8a4c7619529c2e5f
bug 1390847 - remove update-crash-adu-by-build-signature as default job (#3943)

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/ac00e41a4a37925211dd4d625c02adef0cd36c9a
fixes bug 1390847 - delete crash_adu_by_build_signature table and functions (#3964)