1391136 - Handle WebGL context lost in layers-free mode.

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Originally, we check IsContextLost in WebGLContext::GetCanvasLayer(). However, in layers-free mode, we don't use GetCanvasLayer, we'll call InitializeCanvasRenderer. So I move IsContextLost check to InitializeCanvasRenderer.

Comment 1

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: Bug 1391136 - Handle context lost in layers-free mode.

Review commit: https://reviewboard.mozilla.org/r/169416/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/169416/

Comment 2

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8898085 [details]
Bug 1391136 - Handle context lost in layers-free mode.

https://reviewboard.mozilla.org/r/169416/#review174992

::: layout/generic/nsHTMLCanvasFrame.cpp:144
(Diff revision 1)
>            aManager->CreateOrRecycleWebRenderUserData<WebRenderCanvasData>(this, &isRecycled);
>          WebRenderCanvasRendererAsync* data =
>            static_cast<WebRenderCanvasRendererAsync*>(canvasData->GetCanvasRenderer());
>  
>          if (!isRecycled) {
> -          static_cast<nsHTMLCanvasFrame*>(mFrame)->InitializeCanvasRenderer(aDisplayListBuilder, data);
> +          nsHTMLCanvasFrame *canvasFrame = static_cast<nsHTMLCanvasFrame*>(mFrame);

Star to the left, against the type.

Comment 3

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1d935248b404c5532efa54d00137528723bf624f

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/682c2b840724
Handle context lost in layers-free mode. r=jgilbert

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/682c2b840724