Closed
Bug 1391158
Opened 7 years ago
Closed 7 years ago
Add checkLoadURL fast path for extension URLs
Categories
(WebExtensions :: General, enhancement)
WebExtensions
General
Tracking
(firefox57 fixed)
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: kmag, Assigned: kmag)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
We call checkLoadURL *a lot*, and the for the extremely common case of checking an extension URL, a simple substring check is orders of magnitude cheaper than creating a nsIURI and going through the security manager.
|
Assignee | |
Updated•7 years ago
|
Blocks: webext-perf, 1385618
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8898126 [details] Bug 1391158: Optimize checkLoadURL for the common case of extension URLs. https://reviewboard.mozilla.org/r/169474/#review174914
Attachment #8898126 -
Flags: review?(mixedpuppy) → review+
|
|
Assignee | |
Comment 3•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ee33fed596af4461bc2e30fede68dba2c90596c3 Bug 1391158: Optimize checkLoadURL for the common case of extension URLs. r=mixedpuppy
Pushed by maglione.k@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ee33fed596af Optimize checkLoadURL for the common case of extension URLs. r=mixedpuppy
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ee33fed596af
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
|
||
Updated•6 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•