1391170 - Remove the dependency on MediaResource from HTMLMediaElement

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

HTMLMediaElement should depends on the public API of MediaDecoder without knowing its details like MediaResource.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1391170 - lessen the assertion in AddMediaElementToURITable() so we can move MediaDecoder::GetResource() to private.

If AddMediaElementToURITable() is called after the decoder Load failed, mDecoder
will be reset and it is sufficient to assert mDecoder only.

Review commit: https://reviewboard.mozilla.org/r/171006/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/171006/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

This also reduces the surface area of the MediaDecoder API to make it easier for porting to Servo.

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8899687 [details]
Bug 1391170 - lessen the assertion in AddMediaElementToURITable() so we can move MediaDecoder::GetResource() to private.

https://reviewboard.mozilla.org/r/171006/#review176180

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d65d1c6af009
lessen the assertion in AddMediaElementToURITable() so we can move MediaDecoder::GetResource() to private. r=gerald

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/d65d1c6af009