Closed Bug 1391193 Opened 7 years ago Closed 7 years ago

OnFTPControlLog still needed ?

Categories

(Core Graveyard :: Networking: FTP, enhancement)

Product:
Core Graveyard
Component:
Networking: FTP
Version:
52 Branch
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: enrico.weigelt, Unassigned)

Details

It seems that OnFTPControlLog isn't used anymore.

nsDirectoryViewer docks in via nsIFTPChannel and seem to forward to JS.
But I can't find any consumer for that.

This makes nsDirectoryViewer depending on nsIFTPChannel.
searchfox shows that this does still get used by ftp channels (gets called a bit down the line in oninputstreamready on the control channel).
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
Also, bugzilla is not for questions, regardless of whether or not you've been told to stop flooding the mailing lists.
(In reply to Nicholas Hurley [:nwgh][:hurley] (also hurley@todesschaf.org) from comment #1)
> searchfox shows that this does still get used by ftp channels (gets called a
> bit down the line in oninputstreamready on the control channel).

Wait a second ...

It is correct that the OnFTPControlLog callback is called:

https://searchfox.org/mozilla-central/source/xpfe/components/directory/nsDirectoryViewer.cpp#150

BUT: this in turn just calls an jscript function OnFTPControlLog(), which I couldn't find anywhere.
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.