Closed Bug 1391410 Opened 7 years ago Closed 7 years ago

Crash in nsCycleCollector::ScanWhiteNodes

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla57
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox55 --- unaffected
firefox56 --- unaffected
firefox57 + fixed

People

(Reporter: mccr8, Assigned: ehsan.akhgari)

References

Details

(Keywords: regression, topcrash)

Crash Data

This is a long-standing issue, but it seems to have become a top crash in Nightly. I see annotations on these crashes like:
  More references to an object than its refcount, for class nsGenericDOMDataNode
  for instance: bp-b166d28b-f760-4169-a00d-882960170816
I've also seen FragmentOrElement, as in this crash:bp-f11a1a07-f5a3-4672-9cfa-b60ac0170817
Crash Signature: [@ nsCycleCollector::ScanWhiteNodes ]
It looks like this first showed up on Nightly in great number with the 20170815100349 build.
Regression range for the 8-15 build:
  https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=df9beb781895fcd0493c21e95ad313e0044515ec&tochange=564e82f0f289af976da01c2d50507017bbc152b5

Olli, do you have any ideas of what might have caused refcounting of elements to break?
Flags: needinfo?(bugs)
Olli pointed out bug 1386480 in IRC, and I agree that is probably at fault, as the patch looks wrong to me.
Blocks: 1386480
Flags: needinfo?(bugs)
Fixed by backout.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Assignee: nobody → ehsan
status-firefox55: --- → unaffected
status-firefox57: affected → fixed
status-firefox-esr52: --- → unaffected
Target Milestone: --- → mozilla57
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.