1391563 - Check if exporting EventEmitter.emit from devtools/shared/protocol is still necessary

Status: RESOLVED FIXED

(DevTools :: General, enhancement, P1)

Description

[Julian Descottes [:jdescottes]]

Follow up to Bug 1137935.

We should check if exporting EventEmitter.emit is still necessary after migrating out of the sdk event emitter:
http://searchfox.org/mozilla-central/rev/e8c36327cd8c9432c69e5e1383156a74330f11f2/devtools/shared/protocol.js#15

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1391563 - stop exporting event-emitter emit method from devtools protocol.js;

Review commit: https://reviewboard.mozilla.org/r/170198/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/170198/

Comment 2

[Julian Descottes [:jdescottes]]

Simply removed the export and tested locally, seems to be fine.

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=96b19b96c5acd47ac2fb3aa4f98c4a37a7e63f67

Comment 3

[Julian Descottes [:jdescottes]]

Comment on attachment 8898823 [details]
Bug 1391563 - stop exporting event-emitter emit method from devtools protocol.js;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/170198/diff/1-2/

Comment 4

[Julian Descottes [:jdescottes]]

Try seems to be ok with it.

Just sent another push rebased on the latest central: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8ff7f541d86bb3e980f62b6dd35a4d2b3eeb69e9

Comment 5

[Alexandre Poirot [:ochameau]]

Comment on attachment 8898823 [details]
Bug 1391563 - stop exporting event-emitter emit method from devtools protocol.js;

https://reviewboard.mozilla.org/r/170198/#review176940

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e2a683f3be4f
stop exporting event-emitter emit method from devtools protocol.js;r=ochameau

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/e2a683f3be4f