1391687 - Send an event when the user saves an image

Status: VERIFIED FIXED

(Firefox for iOS :: General, defect)

Description

[Simon Basca [:SimonB]]

Build: 918e20ecd
Device: iPad Air 2
iOS: 10.3.3

Steps to reproduce:
1. Go to images.google.com and search for 'images'
2. Long tap on a picture
3. From the context menu, tap on save
4. Check the Leanplum dashboard

Actual result:
- The event "E_Download_Media_Saved_Image" is not triggered.

Expected results;
- The "E_Download_Media_Saved_Image" should be triggered when saving a image to iOS device.

Comment 1

[Bryan Munar (:bkmunar)]

Yup, put it in the wrong place, I think this case is when the user has already allowed Firefox permission to access their photo gallery. I just put it to record when a user FIRST saves an image. My bad!!

Comment 2

[Bryan Munar (:bkmunar)]

Attachment: PR

Comment 3

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: PR https://github.com/mozilla-mobile/firefox-ios/pull/3094

This patch sends an event when the user succesfully saves an image to their photo album. Contrary to the previous code, this patch only sends the event when the save was succesfull. If it failed with a real error, of if it failed because the user denied the request, the event will not be sent.

Comment 4

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8901221 [details] [review]
PR https://github.com/mozilla-mobile/firefox-ios/pull/3094

LGTM

Comment 5

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Landed on master, uplifted to v8.x and v9.x

Comment 6

[Simon Basca [:SimonB]]

Verifying as fix on master b06b848a9f74.

Comment 7

[Simon Basca [:SimonB]]

Verifying as fix on beta 8.3(5817).