Closed Bug 1392054 Opened 7 years ago Closed 7 years ago

Pass the full event or at least event.shiftKey to the callback in toolkit/content/widgets/notification.xml

Categories

(Core :: XUL, enhancement)

Product:
Core
Component:
XUL
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1392055

People

(Reporter: jorgk-bmo, Unassigned)

References

Details

At
https://dxr.mozilla.org/mozilla-central/rev/833f84d0d5c729054a3aa8b3f34735f56fe6436b/toolkit/content/widgets/notification.xml#491
var result = callback(this, button, aEvent.target);

we call a button callback with the event target. It would be beneficial to pass the full event, or at least aEvent.shiftKey.

So the patch would be a one liner adding the extra argument.

Sorry about the NI SPAM, I really can't see who's in charge of this. Please point me to the right person and also adjust the component of this bug.
Hmm, something funny happened and I created three bugs instead of one.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336
Component: XP Toolkit/Widgets: XUL → XUL
You need to log in before you can comment on or make changes to this bug.