1392447 - Stylo: Adjust Servo_StyleSheet_GetOrigin return type for Linux32 ABI

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P1)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Similiar to the changes in bug 1390691, another FFI `Servo_StyleSheet_GetOrigin` was added by bug 1382925 which needs to adjusted for Linux 32-bit.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Bug 1392447 - Fix up Servo_StyleSheet_GetOrigin for Linux 32-bit ABI.

Bindgen bitfield enums don't work as return values with the Linux 32-bit ABI at
the moment because they wrap the value in a struct.

This causes the Rust side to believe the caller will pass along space for the
struct return value, while C++ believes it's just an integer value.

Review commit: https://reviewboard.mozilla.org/r/170934/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/170934/

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8899626 [details]
Bug 1392447 - Fix up Servo_StyleSheet_GetOrigin for Linux 32-bit ABI.

https://reviewboard.mozilla.org/r/170934/#review176314

r=me

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

https://github.com/servo/servo/pull/18190

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8899626 [details]
Bug 1392447 - Fix up Servo_StyleSheet_GetOrigin for Linux 32-bit ABI.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/170934/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8acd319d4e34
Fix up Servo_StyleSheet_GetOrigin for Linux 32-bit ABI. r=emilio

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/8acd319d4e34