Closed Bug 1392504 Opened 7 years ago Closed 7 years ago

mach clang-format should only format changed files by default

Categories

(NSS :: Build, enhancement)

Product:
NSS
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mt, Assigned: mt)

Details

The most common reason to run `mach clang-format` is that you have made some changes and they need to be reformatted.  So why not detect changes and run clang-format on those changes?

You can always run `./mach clang-format .` to force it to check everything according to its rules, but that's not likely to be needed.

I also ran autopep8 on `mach` and it fixed a few things.  I wonder if we should insist on that for python files...
https://nss-review.dev.mozaws.net/D418
Assignee: nobody → martin.thomson
Running autopep8 on other python files sounds like a good idea.
You need to log in before you can comment on or make changes to this bug.