1392685 - Pocket'ing items from Activity Stream results in the Pocket icon appearing outside of the URL bar

Status: VERIFIED FIXED

(Firefox :: Pocket, defect, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

STR:

1) Ensure you have a Pocket account set up so that you can Pocket things, and that Activity Stream is enabled (browser.newtabpage.activity-stream.enabled)
2) Go to about:newtab
3) Make sure "Recommended by Pocket" is enabled. If it's not, click on the gear icon in the top right, and ensure "Recommended by Pocket" is checked.
4) Once some Pocket recommendations show up, hover your mouse over the thumbnail until the ... icon appears in the top right
5) Click on the ... icon, and choose "Save to Pocket"

ER:

Unsure. I don't think what we're currently doing is right though.

AR:

See this screencast: https://www.screencast.com/t/mpU4EIlDPArd

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1392685 - Collapse the urlbar-icon-wrapper when the pageproxystate is invalid, instead of just the urlbar-icon inside of it.

Review commit: https://reviewboard.mozilla.org/r/172306/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/172306/

Comment 2

[Drew Willcoxon :adw]

It's by design that the panel is anchored on the site identity icon in this case (see bug 1385418, bug 1388528), so I'll remove that part from the summary for clarity.

Comment 3

[Drew Willcoxon :adw]

Comment on attachment 8900868 [details]
Bug 1392685 - Collapse the urlbar-icon-wrapper when the pageproxystate is invalid, instead of just the urlbar-icon inside of it.

https://reviewboard.mozilla.org/r/172306/#review177618

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Drew Willcoxon :adw from comment #2)
> It's by design that the panel is anchored on the site identity icon in this
> case (see bug 1385418, bug 1388528), so I'll remove that part from the
> summary for clarity.

Yeah, I knew that so didn't try to change it, but didn't realize that it was mentioned in the summary. Thanks for the quick review!

Comment 5

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 0727b24bb4c3 -d 1e7e3c146e8c: rebasing 415655:0727b24bb4c3 "Bug 1392685 - Collapse the urlbar-icon-wrapper when the pageproxystate is invalid, instead of just the urlbar-icon inside of it. r=adw" (tip)
merging browser/base/content/browser.css
warning: conflicts while merging browser/base/content/browser.css! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8900868 [details]
Bug 1392685 - Collapse the urlbar-icon-wrapper when the pageproxystate is invalid, instead of just the urlbar-icon inside of it.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/172306/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dac8634cb381
Collapse the urlbar-icon-wrapper when the pageproxystate is invalid, instead of just the urlbar-icon inside of it. r=adw

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/dac8634cb381

Comment 9

[Stefan [:StefanG_QA]]

User Agent    Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0
Build   ID    20170830100230

This bug fix is Verified with latest Nightly 57.0a1 on Windows 10 and OS X!