1393056 - Count open WebSockets owned by an nsGlobalWindow

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Andreas Farre [:farre]]

To be able to not throttle timeouts in the TimeoutManager when there are active web sockets, we need to keep tabs on the amount of websockets opened, as well as closed.

Comment 1

[Andreas Farre [:farre]]

Attachment: 0001-Bug-1393056-Make-it-possible-to-count-open-WebSocket.patch

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8900294 [details] [diff] [review]
0001-Bug-1393056-Make-it-possible-to-count-open-WebSocket.patch

Shouldn't we count this per top level inner window, similar to IDB connection.
We're supposed to throttle or not-throttle tabs after all, not some iframes in tabs, as far as I know.

Comment 3

[Andreas Farre [:farre]]

Attachment: 0001-Bug-1393056-Make-it-possible-to-count-open-WebSocket.patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c59c1c41a7726b3e6892022d890f8df680b695f4&group_state=expanded

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8903194 [details] [diff] [review]
0001-Bug-1393056-Make-it-possible-to-count-open-WebSocket.patch

In general, could you use -p -U 8 when generating patches.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/448006f5fb18
Make it possible to count open WebSockets on the main thread. r=smaug

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/448006f5fb18

Comment 7

[Ben Kelly [:bkelly, not reviewing]]

Was the intention in this bug to avoid only budget based throttling of sites using websocket?  It seems this bug did not prevent our normal 1second background throttle if the site is using websockets.  Was this intentional?

Comment 8

[Andreas Farre [:farre]]

Yep, that was intentional. We're aligning with the behaviour of Chrome here in that we always, with the exception of audio, allow the 1s throttling.