Closed Bug 1393271 Opened 7 years ago Closed 4 years ago

Use more descriptive exceptions in moztelemetry

Categories

(Data Platform and Tools :: General, enhancement, P2)

Product:
Data Platform and Tools
Component:
General
Type:
enhancement
Points:
1

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: bugzilla, Unassigned)

Details

The particular issue that prompted this bug is that specifying a bad histogram name in `get_pings_properties` throws a KeyError:
  File "/mnt/anaconda2/lib/python2.7/site-packages/moztelemetry/histogram.py", line 135, in __init__
    name, histograms_definition[re.sub("^STARTUP_", "", proper_name)])
KeyError: 'NETWORK_RACE_CACHE_WITH_NETWORK_USAGE'

In this specific case, we should throw a custom exception with a better error message specifies exactly what happened ("Histogram <name> does not exist").

I'm sure there are a few other places in moztelemetry where we could provide better error messages to the end user as well.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WONTFIX
Component: Telemetry APIs for Analysis → General
You need to log in before you can comment on or make changes to this bug.