Closed Bug 1393307 Opened 7 years ago Closed 7 years ago

Add a Toast or Modal to confirm actions that don't have a user perceivable change.

Categories

(Firefox for iOS :: Menu and Toolbar, enhancement, P3)

Product:
Firefox for iOS
Component:
Menu and Toolbar
Platform:
Other
iOS
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Tracking Flags:
Tracking Status
fxios 10.0 ---
fxios-v10.0 --- verified
fxios-v11.0 --- verified

People

(Reporter: farhan, Unassigned)

References

Details

(Whiteboard: [Photon])

Attachments

(1 file)

Pull request
55 bytes, text/x-github-pull-request
farhan
: review+
Details | Review 
For actions such as bookmark and "Add to reading list" show a toast or modal to signal to the user that an action was completed. 

The following menu options need some sort of confirmation
- Copy URL
- Add Bookmark
- Add to reading List
How this looks will depend on the UI. But for a starter, reusing SimpleToast is a good first step.
Priority: -- → P3
Attached file Pull request — 

        Attachment #8915727 -
        Flags: review?(fpatel)

    
    

    
  
https://github.com/mozilla-mobile/firefox-ios/commit/06f686c01eb05641aa2737127e0271866926120e
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED

    
  

        Attachment #8915727 -
        Flags: review?(fpatel) → review+
Whiteboard: [Photon] → [Photon][needsuplift]

    
    

    
  
Verifying as fix on master fac4e03e6103 and beta 10.0(7025). The toast is displayed when Copying a URL, Adding a Bookmark, Adding a page to Reading List from the page action menu.
Status: RESOLVED → VERIFIED

          status-fxios-v10.0:
          --- → verified

          status-fxios-v11.0:
          --- → verified

    
  
Whiteboard: [Photon][needsuplift] → [Photon]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: