1393411 - Bookmarks and History subviews are cut off

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[ovidiu boca[:Ovidiu]]

Attachment: Screen Shot 2017-08-24 at 2.47.43 PM.png

[Affected versions]:

Nightly 57.0a1(2017-08-24)

[Affected platforms]:

Tested on Mac OS X 10.10 and Mac Os X 10.12, on other OSes the latest Nightly didn't land. I will update this bug after I test on the latest Nightly.

[Steps to reproduce]:

 Click on Menu -> library -> Bookmarks or History

[Actual result]:

The bookmarks are cut off.

[Expected result]:

The bookmarks are displayed correctly. 

Please see the attachment 

Note: This is a regression, on the Nightly from 2017-08-23 I can't reproduce this. I tried to use mozregression but I have some issues and I can't get a regression window.

Comment 1

[Dão Gottwald [:dao]]

Hmm, this could be a regression from bug 1391017 which moved toolbarbutton.bookmark-item { max-width: 13em; } from being directly in browser.css to a different place in toolbarbuttons.inc.css, so I guess it could take precedence over some other rule that ends up before this in browser.css.

Comment 2

[Dão Gottwald [:dao]]

Or maybe it's :not(#bookmarks-toolbar-placeholder) that boosts this rule's specificity.

Comment 3

[:Gijs (he/him)]

I can reproduce, but not a lot of stuff landed inbetween these 2 nightlies, so I'm puzzled as to what would have caused this... trying mozregression myself right now. Already tested turning stylo on/off, made no difference.

Comment 4

[:Gijs (he/him)]

(In reply to Dão Gottwald [::dao] from comment #1)
> Hmm, this could be a regression from bug 1391017 which moved
> toolbarbutton.bookmark-item { max-width: 13em; } from being directly in
> browser.css to a different place in toolbarbuttons.inc.css, so I guess it
> could take precedence over some other rule that ends up before this in
> browser.css.

Ah, this would be plausible. I'll see if I can confirm with mozregression.

Comment 5

[:Gijs (he/him)]

Yep, https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=6ccd5cf829e2af1d068d2ac87e80bfe0687f9136&tochange=b45c8f18e2463f0f20130236e86aeb8f51b82b12 .

Testing with the style editor, reducing the specificity by removing the :not(...) fixes this.

Comment 6

[:Gijs (he/him)]

Patch incoming. Not really sure if max-width: none is more or less appropriate than unset, let me know if you feel strongly.

Comment 7

[:Gijs (he/him)]

Attachment: Bug 1393411 - avoid setting the max-width of bookmark items with too great a specificity,

Review commit: https://reviewboard.mozilla.org/r/172142/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/172142/

Comment 8

[Dão Gottwald [:dao]]

Comment on attachment 8900696 [details]
Bug 1393411 - avoid setting the max-width of bookmark items with too great a specificity,

https://reviewboard.mozilla.org/r/172142/#review177406

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/109578ac95f6
avoid setting the max-width of bookmark items with too great a specificity, r=dao

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/109578ac95f6

Comment 14

[ovidiu boca[:Ovidiu]]

I verified this on Mac OS X 10.10, Windows 10 x64 with Nightly 57.0a1(2017-08-25) and I can confirm the fix.