Closed
Bug 1393417
Opened 7 years ago
Closed 7 years ago
Android and iOS icons aren't displayed with high contrast themes
Categories
(Firefox :: Settings UI, defect, P3)
Tracking
()
VERIFIED
FIXED
Firefox 58
Tracking | Status | |
---|---|---|
firefox55 | --- | unaffected |
firefox56 | --- | unaffected |
firefox57 | --- | verified |
firefox58 | --- | verified |
People
(Reporter: hyacoub, Assigned: rickychien)
References
(Blocks 1 open bug)
Details
(Whiteboard: [photon-preference])
Attachments
(2 files)
47.51 KB,
image/png
|
Details | |
59 bytes,
text/x-review-board-request
|
Sylvestre
:
approval-mozilla-beta+
|
Details |
[Affected versions]: Nightly 57.0a1 [Affected platforms]: Platforms: Windows 10 x 64 and Ubuntu 16.04 x64. [Steps to reproduce]: 1. Launch Firefox. 2. Go to "about:preferences". 3. Go to Firefox Account. [Expected result]: Android and iOS icons should be displayed. [Actual result]: Android and iOS icons aren't displayed with high contrast themes
Reporter | ||
Updated•7 years ago
|
Blocks: 1357306
status-firefox55:
--- → unaffected
status-firefox56:
--- → unaffected
Whiteboard: [photon-preference][triage]
Assignee | ||
Updated•7 years ago
|
Priority: -- → P3
Updated•7 years ago
|
Whiteboard: [photon-preference][triage] → [photon-preference]
Updated•7 years ago
|
Flags: qe-verify+
QA Contact: hani.yacoub
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → rchien
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8913050 [details] Bug 1393417 - Make Preferences Android and iOS icons highlight in high contrast themes https://reviewboard.mozilla.org/r/184438/#review189676 ::: browser/themes/shared/incontentprefs/preferences.inc.css:584 (Diff revision 1) > margin-inline-start: 2px; > margin-inline-end: 4px; > width: 20px; > height: 20px; > vertical-align: text-bottom; > + -moz-context-properties: fill, stroke; It looks like you're not using stroke, so you shouldn't set it here.
Attachment #8913050 -
Flags: review+
Comment hidden (mozreview-request) |
Pushed by rchien@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/75620646ccb8 Make Preferences Android and iOS icons highlight in high contrast themes r=dao
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/75620646ccb8
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Updated•7 years ago
|
Attachment #8913050 -
Flags: review?(jaws)
Assignee | ||
Comment 6•7 years ago
|
||
Comment on attachment 8913050 [details] Bug 1393417 - Make Preferences Android and iOS icons highlight in high contrast themes Approval Request Comment [Feature/Bug causing the regression]: [User impact if declined]: minor visual issue only in Windows high contrast mode [Is this code covered by automated tests?]: no [Has the fix been verified in Nightly?]: not yet [Needs manual test from QE? If yes, steps to reproduce]: see description [List of other uplifts needed for the feature/fix]: no [Is the change risky?]: minor [Why is the change risky/not risky?]: minor visual issue [String changes made/needed]: none
Attachment #8913050 -
Flags: approval-mozilla-beta?
Reporter | ||
Comment 7•7 years ago
|
||
Build ID: 20171001220301 User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0 Verified as fixed on Firefox Nightly 58.0a1 on Windows 10 x 64, Windows 7 x32 and Ubuntu 16.04 x64.
Comment 8•7 years ago
|
||
Comment on attachment 8913050 [details] Bug 1393417 - Make Preferences Android and iOS icons highlight in high contrast themes Fix a new visual regression, taking it Should be in 57b5
Attachment #8913050 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 9•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/2445f6df733d
Reporter | ||
Comment 10•7 years ago
|
||
Build ID: 20171002181526 User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0 Verified as fixed on Firefox Beta 57.0b5 on Windows 10 x 64, Windows 7 x32 and Ubuntu 16.04 x64.
Updated•7 years ago
|
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•