1393435 - Remove unnecessary inclusions of nsExceptionHandler.h and CrashReporterHost.h

Status: RESOLVED FIXED

(Firefox :: General, enhancement)

Description

[Gabriele Svelto [:gsvelto] (PTO)]

+++ This bug was initially created as a clone of Bug #1323979 +++

While working on bug 1323979 I've noticed that touching nsExceptionHandler.h rebuilds half of our tree which is... unpleasant to say the least. I've also noticed that there's quite a few inclusions that are either unnecessary or redundant so we should get rid of them.

(on a side note, it seems to me that the includehell bug has received too little love as of late, it would be time to pick it up again before our preprocessor output spills out of our computers and onto the floor)

Comment 1

[Gabriele Svelto [:gsvelto] (PTO)]

I've got a patch ready for this but I haven't checked if it builds on all platforms yet, the try run is here:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a86643d5deff41570541e044e2d04013b6834800

Comment 2

[Gabriele Svelto [:gsvelto] (PTO)]

Attachment: Bug 1393435 - Remove unnecessary inclusions of the crash reporter header files;

Review commit: https://reviewboard.mozilla.org/r/172204/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/172204/

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8900741 [details]
Bug 1393435 - Remove unnecessary inclusions of the crash reporter header files;

https://reviewboard.mozilla.org/r/172204/#review177540

Yay, less header coupling. :) Thanks!

Comment 4

[Gabriele Svelto [:gsvelto] (PTO)]

Thanks for the quick review! The try run looks green, landing this.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a516dafb1006
Remove unnecessary inclusions of the crash reporter header files; r=mconley

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a516dafb1006