Closed
Bug 1394186
Opened 7 years ago
Closed 7 years ago
Sentry is not correctly logging SQL from SwiftData
Categories
(Firefox for iOS :: Data Storage, defect, P1)
Tracking
()
RESOLVED
FIXED
Iteration:
1.29
Tracking | Status | |
---|---|---|
fxios | 9.0 | --- |
People
(Reporter: justindarc, Assigned: justindarc)
References
Details
(Whiteboard: [MobileCore][DataLoss])
Attachments
(1 file)
55 bytes,
patch
|
rnewman
:
review+
|
Details | Diff | Splinter Review |
We currently print: `"SQL error. Error code: \(error.code), \(error) for SQL \(sqlStr.characters.prefix(500))."` to Sentry which is resulting in an error like: SQL error. Error code: 1, Error Domain=org.mozilla Code=1 "SQL error or missing database no such table: tabs" UserInfo={NSLocalizedDescription=SQL error or missing database no such table: tabs} for SQL CharacterView(_core: Swift._StringCore(_baseAddress: Optional(0x00000001c44a8600), _countAndFlags: 39, _owner: Optional(Swift.ManagedBuffer<Swift._HeapBufferHeader<Swift._StringBufferIVars>, Swift.UInt16>)), _coreOffset: 0). We need to convert `CharacterView` back to a `String` for Sentry to properly display it.
Assignee | ||
Comment 1•7 years ago
|
||
Marking as P1 9.0 blocker and assigning to myself. We may need to land this in a new beta ASAP to help track down the cause of Bug 1394185. NI? :farhan to give him a heads up that we may need to ship this fix while :st3fan is out.
Assignee: nobody → jdarcangelo
Blocks: 1394185
Status: NEW → ASSIGNED
Iteration: --- → 1.29
Flags: needinfo?(fpatel)
Priority: -- → P1
Whiteboard: [MobileCore][DataLoss]
Assignee | ||
Comment 2•7 years ago
|
||
Simple 2-line patch. We need to ship this in a beta right away.
Attachment #8901525 -
Flags: review?(fpatel)
Comment 3•7 years ago
|
||
Comment on attachment 8901525 [details] [diff] [review] GitHub Pull Request Review of attachment 8901525 [details] [diff] [review]: ----------------------------------------------------------------- Blargh, my bad.
Attachment #8901525 -
Attachment is patch: true
Attachment #8901525 -
Attachment mime type: text/x-github-pull-request → text/plain
Attachment #8901525 -
Flags: review?(fpatel) → review+
Assignee | ||
Comment 4•7 years ago
|
||
Landed on master: https://github.com/mozilla-mobile/firefox-ios/commit/59b53f100d94e71ec6cfb44d6b6c0aaec333f010 Landed on v9.x: https://github.com/mozilla-mobile/firefox-ios/commit/ce51317df0594633fedf68ed4492915ed1b97444
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Flags: needinfo?(fpatel)
You need to log in
before you can comment on or make changes to this bug.
Description
•