1394250 - css border-radius not working for xul:label

Status: RESOLVED WORKSFORME

(Core :: XUL, defect, P3)

Description

[Harald Gutsche]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0
Build ID: 20170823004136

Steps to reproduce:

use a userstyle to style a xul:label element with border or background with rounded corners:

label
  {
  border-radius: 7px !important;
  border: solid red 1px !important;
  }

this should surround all label (menu items etc.) with a rounded border.

I tried a star as a selector and from what I see, I think only xul:label is affected by this issue.
However I found one label, that gets a rounded border: the text on tree style tabs.


Actual results:

no rounded corners


Expected results:

rounded corners

Comment 1

[Harald Gutsche]

a checkbox-label seems to work, too

Comment 2

[Neil Deakin]

The borders aren't drawn by the label, so I'm not sure why this doesn't work.

Is this a regression?

Comment 3

[Harald Gutsche]

the radius worked for several years until recently.
I am not sure, when it changed.
Note, the background is affected, too.

Comment 4

[Harald Gutsche]

it's interesting, that several labels still work.
I created this user style:

@namespace url(http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul);

label
  {
  border-radius: 2em !important;
  border: solid magenta 1px !important;
  }

and a few labels are rounded, e.g. in the Stylish add-on, the below the list in "Visit userstyles.org for more information..." userstyles.org gets a rounded border. I think labels, that are links get rounded, another one is in Add-ons - Appearance ("Choose from thousands..." in Add-On manager in All in One Sidebar).
Also the tab labels in Tree-Style-Tab are rounded.
Also checkbox labels and radio button labels.
But checkboxes and radio buttons in menus are not rounded.
In the "Burger" menu, I see rounded icon labels.

Comment 5

[Harald Gutsche]

I tested this with an empty profile and chrome/userChrome.css to be sure (already did this before).

The results are the same. E.g. tab labels, tooltip labels and icon labels in burger menu work, but "New Tab" button or menu labels don't.

Comment 6

[Harald Gutsche]

tried available packages in my configured debian/ubuntu repositories:

works in firefox_49.0+build4-0ubuntu2_amd64.deb
works in firefox_54.0+build3-0ubuntu0.16.10.1_amd64.deb

Comment 7

[Harald Gutsche]

more complete:

// working:     49.0+build4-0ubuntu2
// working:     54.0+build3-0ubuntu0.16.10.1

// not working: 55.0.2+build1-0ubuntu0.16.04.1
// not working: 55.0.3-1
// not working: 56.0~b12+build1-0ubuntu0.16.04.1

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Pretty sure this works now.