1394783 - Unnecessary context menu options for webrtc call

Status: NEW

(Toolkit :: Video/Audio Controls, defect, P4)

Description

[Bogdan Maris, Desktop QA]

[Note]:
- This is a bug to address https://bugzilla.mozilla.org/show_bug.cgi?id=1137598#c3

[Affected versions]:
- Firefox 55.0.3
- Firefox 56.0b7
- Latest nightly 57.0a1

[Affected platforms]:
- Windows 10 64bit
- macOS 10.12.6
- Ubuntu 16.04 32bit

[Steps to reproduce]:
1. Start a webrtc call using any service that supports this 
(eg: Tokbox, Jitsi, Cisco Spark, https://mozilla.github.io/webrtc-landing/gum_test.html etc)
2. Right click the video

[Expected result]:
- There is no additional controls for webrtc calls in context menu.

[Actual result]:
- There are a few controls that either do nothing or duplicate the controls from the service used, oh and a nav bar is displayed in the bottom of the video.

[Regression range]:
- This is not a regression, it reproduces on old Fx builds (I tried 43.0) that support webRTC as well.

Comment 1

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

https://mozilla.github.io/webrtc-landing/gum_test.html is getUserMedia, so this applies to all MediaStreams, not just "webrtc calls".

Enabled, I see: Pause/Play, Mute/Unmute, Show/Hide Controls, (Exit) Full Screen, Save Snapshot As..., and Inspect Element.

All of these seem to have a function, except Loop, and work when I try them. Are you saying none of these should be here?

Regardless, this seems like a playback issue, not specific to WebRTC.

Comment 2

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

This is an issue with the controls, not playback itself.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

I think we could do something where we don't show the playback controls if video.srcObject.toString().toLower().includes("mediastream")