1395112 - (stylo-everywhere) Remove the old style system (and use Stylo everywhere)

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P2)

Description

[Henri Sivonen (:hsivonen)]

Once stylo is enabled on all platforms, we should remove the old style system in the interest of clean-ups and code size.

Comment 1

[Cameron McCormack (:heycam)]

I have some WIP patches to remove the old style system code, and it results in libxul.so shrinking by 993 KiB.

Comment 2

[Cameron McCormack (:heycam)]

(On Linux x64.)

Comment 3

[Cameron McCormack (:heycam)]

Tested again, with --enable-release:

stylo:disabled, old style:enabled  - 87,884,896
stylo:enabled,  old style:enabled  - 93,660,448
stylo:enabled,  old style:disabled - 92,906,592

So only around 736 KB.  And the size regression from enabling stylo is more like 5.5 MiB.

Comment 4

[Chris Peterson [:cpeterson]]

P2 because we need to remove (or at least disable at compile-time) the old style system code before we ship Stylo-android or Stylo-chrome.

Comment 5

[Simon Sapin (:SimonSapin)]

Isn’t it the reverse? Don’t we need to stop using the old style system (on Android and in chrome) before we disable/remove it?

Comment 6

[Chris Peterson [:cpeterson]]

(In reply to Simon Sapin (:SimonSapin) from comment #5)
> Isn’t it the reverse? Don’t we need to stop using the old style system (on
> Android and in chrome) before we disable/remove it?

Yeah. I just meant that we want to disable the old style system in the same release we ship on Android and in chrome.

Comment 7

[Jonathan Watt [:jwatt]]

We didn't wait for mingw builds to be fixed (bug 1390583 and bug 1443471). Instead the mingw builds are being disabled for now (bug 1447414).

Comment 8

[Boris Zbarsky [:bzbarsky]]

Fixed, right?

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Yup!