1395276 - $ and $$ console commands throw system principal errors

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Oriol Brufau [:Oriol]]

Go to http://example.com
Enter this code in the web console:

    try{ $$(':foo') }catch(err){ err }

Result: Object {  }
Expected: DOMException {  }

That's because the error object that is thrown belongs to a system principal, so http://example.com is not allowed to access it.

Comment 1

[Oriol Brufau [:Oriol]]

Attachment: console-queryselector-error.patch

Comment 2

[Oriol Brufau [:Oriol]]

Attachment: console-queryselector-error.patch

Argh, I always forget the space after `catch`.

Comment 3

[Oriol Brufau [:Oriol]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6a7fed6e6fe13e77c75d34fbf9eca8848a911774

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8902837 [details] [diff] [review]
console-queryselector-error.patch

Passing it to Jim, I don't feel confident enough to review these changes.

Comment 5

[Oriol Brufau [:Oriol]]

Jim, can you review this, please, so that bug 1394559 can be fixed?

Comment 6

[Jim Blandy :jimb]

Comment on attachment 8902837 [details] [diff] [review]
console-queryselector-error.patch

Review of attachment 8902837 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Thanks, and sorry for the delay.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/112fa91b456f
Make $ and $$ console commands throw errors created in the debuggee global. r=jimb

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/112fa91b456f