1395436 - Tab strip overflow indicators overlap the nav bar (OS X 10.9)

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Clément Lefèvre]

As visible on the joined screnshot, the first tabs on the left and last tab on the right can have a little shadow line overlapping the lower bar.
This can be seen only if the bar have a dark color and if there are enough opened tabs to scroll tabs on left or on right.

STR:
- Use a theme with dark colors on the tab bar (either default or dark compact theme on OS X)
- Open many tabs, at least 15/20 so that arrows to scroll there are present on left and right of the bar.
- Move to one of the middle tabs so that user can click the arrows to slide tabs on both the left and on the right.
- You'll then see that underlying shadow under first and last tab of the line as seen on screenshot.


This can not be seen or reproduced if using the theme is the light one.

Comment 1

[Clément Lefèvre]

Attachment: The tab bar with the shadow underline issue

Comment 2

[Clément Lefèvre]

Attachment: Same screenshot with tab on the left selected

Joined, the same screenshot with the tab on the left selected.
We can see more easily this way the shadow culprit of the problem.

It does the same thing with the tab on the right.

Comment 3

[Clément Lefèvre]

My guess is that for some unknown reason, the shadow is a little bit (one or two pixels) lower when the tab bar is dark.

Comment 4

[Clément Lefèvre]

I'm not sure this is 100% related to the bug you pointed though: this bug is way older while I noticed this only with the new Photon design (no issue before), and mine was found on computers with a lot lower resolutions (no HiDPI).
Screenshots come from a 1440x900 macbook pro. I couldn't reproduce on a W10 & Full HD laptop. I can test a W7 with 1280x1024 resolution.
I have no access to Linux computers as of now to check with the design on those though.

Comment 5

[Dão Gottwald [:dao]]

I can reproduce this on Windows at 150% DPI.

Comment 6

[Dão Gottwald [:dao]]

Oh, if you can reproduce without HiDPI, we're still missing something since so far nobody else seems to be able to reproduce this.

Comment 7

[Clément Lefèvre]

(In reply to Dão Gottwald [::dao] from comment #6)
> Oh, if you can reproduce without HiDPI, we're still missing something since
> so far nobody else seems to be able to reproduce this.

I can't reproduce it on Windows, but it's permanently here on OS X 10.9 with a 1440x900 screen, then why unconfirm the bug?

Comment 8

[Dão Gottwald [:dao]]

(In reply to Clément Lefèvre from comment #7)
> (In reply to Dão Gottwald [::dao] from comment #6)
> > Oh, if you can reproduce without HiDPI, we're still missing something since
> > so far nobody else seems to be able to reproduce this.
> 
> I can't reproduce it on Windows, but it's permanently here on OS X 10.9 with
> a 1440x900 screen, then why unconfirm the bug?

Because so far nobody else has reported seeing this on Mac.

Comment 9

[Pascal Chevrel:pascalc (PTO until April 26)]

I can reproduce with 150% DPI on Linux with the Light theme.

Comment 10

[Dão Gottwald [:dao]]

The 150% DPI issue is bug 1204376.

Comment 11

[ovidiu boca[:Ovidiu]]

Attachment: Screen Shot 2017-09-13 at 16.52.10.png

I tested this issue on Mac OS X 10.9 and I attached a print screen. Clément can you please take a look over the attachment and tell me if this bug is about the areas that I marked with red in the attachment, just to be sure. Thanks

Comment 12

[Clément Lefèvre]

(In reply to ovidiu boca[:Ovidiu] from comment #11)
> Created attachment 8907607 [details]
> Screen Shot 2017-09-13 at 16.52.10.png
> 
> I tested this issue on Mac OS X 10.9 and I attached a print screen. Clément
> can you please take a look over the attachment and tell me if this bug is
> about the areas that I marked with red in the attachment, just to be sure.
> Thanks

Yes that's it.
May I rechange the status to NEW, then?

Comment 13

[ovidiu boca[:Ovidiu]]

I will move it to New, but I don't know how much support we offer for Mac OS X 10.9.

Comment 14

[Clément Lefèvre]

(In reply to ovidiu boca[:Ovidiu] from comment #13)
> I will move it to New, but I don't know how much support we offer for Mac OS
> X 10.9.

From the places I asked, for example on #photon-visual or some other places, 10.9 is still supposed to be supported as oldest supported OS X (10.8 isn't), but isn't really tested internally as tests are done on 10.12 and sometimes 10.10.

Comment 15

[Clément Lefèvre]

Might be worth noting: This glitch disappear when the "Cuztomize…" view is active, and comes back once user get out of the "Customize…" view.

Comment 16

[Dão Gottwald [:dao]]

Can you still reproduce this in the latest Nightly?

Comment 17

[Clément Lefèvre]

Attachment: current_tab_bar

(In reply to Dão Gottwald [::dao] from comment #16)
> Can you still reproduce this in the latest Nightly?

No, this isn't here anymore. I guess bug can therefore be closed, but does it need to have the commit that fixed it? Closing as FIXED? WFM?

On the other hand, I joined a new screenshot of the tab bar: while the present bug isn't here anymore, there's now a shadow that is makingan abrupt horizontal cut at the bottom of the tab. It seems it landed in the same time as this bug was fixed, do you know which bug that might be?

I think filing another bug as follow-up would be worth it as polishing, by modifying the shadow so that there isn't that abrupt cut, for example dimming/shading off/bluring it on the bottom (I don't now what the correct word is in this context).

Comment 18

[Dão Gottwald [:dao]]

(In reply to Clément Lefèvre from comment #17)
> Created attachment 8923381 [details]
> current_tab_bar
> 
> (In reply to Dão Gottwald [::dao] from comment #16)
> > Can you still reproduce this in the latest Nightly?
> 
> No, this isn't here anymore. I guess bug can therefore be closed, but does
> it need to have the commit that fixed it? Closing as FIXED? WFM?
> 
> On the other hand, I joined a new screenshot of the tab bar: while the
> present bug isn't here anymore, there's now a shadow that is makingan abrupt
> horizontal cut at the bottom of the tab. It seems it landed in the same time
> as this bug was fixed, do you know which bug that might be?
> 
> I think filing another bug as follow-up would be worth it as polishing, by
> modifying the shadow so that there isn't that abrupt cut, for example
> dimming/shading off/bluring it on the bottom (I don't now what the correct
> word is in this context).

That sounds like bug 1411648. Otherwise please file a new one.

Comment 19

[ovidiu boca[:Ovidiu]]

(In reply to Clément Lefèvre from comment #17)
> Created attachment 8923381 [details]
> current_tab_bar
> 
> (In reply to Dão Gottwald [::dao] from comment #16)
> > Can you still reproduce this in the latest Nightly?
> 
> No, this isn't here anymore.

I tested this on Mac OS X 10.9 with FF Nightly 58.0a1(2017-11-05) and I can't reproduce this also based on the Clément's comment I will mark this as a verified fix.